Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Dotter depends on configuration too much when undeploying #55

Open
SuperCuber opened this issue Mar 10, 2021 · 4 comments
Open

[BUG] Dotter depends on configuration too much when undeploying #55

SuperCuber opened this issue Mar 10, 2021 · 4 comments

Comments

@SuperCuber
Copy link
Owner

Reproduction

  • Deploy with symlink a -> b.
  • Remove the file a
  • Run an undeploy

Expected behavior

b should be deleted

Actual behavior

[ERROR] Failed to undeploy
Caused by:
    get a configuration
    expand files that are directories
    expand file "a"
    read file's metadata
    The system cannot find the file specified. (os error 2)
@poperigby
Copy link

I think I'm running into this issue. I deleted a directory in the dotter repo, and now it's giving me a bunch of these errors:

[ERROR] Failed to delete symlink "ranger/plugins/devicons2/screenshot.png" -> "/home/cassidy/.config/ranger/plugins/devicons2/screenshot.png"
Caused by:
    detect symlink's current state
    get real path of source
    No such file or directory (os error 2)

@Diomendius
Copy link
Contributor

I've opened a PR which should fix your issue, @lumbo7332. It doesn't quite tackle the core problem of this issue, which seems to be that Dotter config entries which point to nonexistent files cause hard errors rather than warnings, but if you delete a file or directory and remove the corresponding config entries, Dotter should no longer crash because the still-existing symlinks are broken.

@CanRau
Copy link

CanRau commented Jan 23, 2024

I think this could be closed as #87 has been merged, correct?

@SuperCuber
Copy link
Owner Author

@CanRau IIRC the fix only works for one of the platforms. I need to revisit this 🙃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants