Merge pull request #760 from mjkillough/pca9685

UncleRus · web-flow · commit 503e66a50041 · 2020-08-17T10:24:23.000+05:00
Fix full on/off in pca9685.
diff --git a/extras/pca9685/pca9685.c b/extras/pca9685/pca9685.c
@@ -185,6 +185,7 @@ void pca9685_set_pwm_value(i2c_dev_t *dev, uint8_t channel, uint16_t val)
     if (val == 0)
     {
         // Full off
+        // Takes precedence over full on.
         write_reg(dev, reg + OFFS_REG_LED_OFF, LED_FULL_ON_OFF);
     }
     else if (val < 4096)
@@ -195,6 +196,8 @@ void pca9685_set_pwm_value(i2c_dev_t *dev, uint8_t channel, uint16_t val)
     }
     else
     {
+        // Clear full off, as it takes precedence over full on.
+        write_reg(dev, reg + OFFS_REG_LED_OFF, 0);
         // Full on
         write_reg(dev, reg + OFFS_REG_LED_ON, LED_FULL_ON_OFF);
     }

Original file line number	Diff line number	Diff line change
`@@ -185,6 +185,7 @@ void pca9685_set_pwm_value(i2c_dev_t *dev, uint8_t channel, uint16_t val)`
`185`	`185`	`if (val == 0)`
`186`	`186`	`{`
`187`	`187`	`// Full off`
	`188`	`+ // Takes precedence over full on.`
`188`	`189`	`write_reg(dev, reg + OFFS_REG_LED_OFF, LED_FULL_ON_OFF);`
`189`	`190`	`}`
`190`	`191`	`else if (val < 4096)`
`@@ -195,6 +196,8 @@ void pca9685_set_pwm_value(i2c_dev_t *dev, uint8_t channel, uint16_t val)`
`195`	`196`	`}`
`196`	`197`	`else`
`197`	`198`	`{`
	`199`	`+ // Clear full off, as it takes precedence over full on.`
	`200`	`+ write_reg(dev, reg + OFFS_REG_LED_OFF, 0);`
`198`	`201`	`// Full on`
`199`	`202`	`write_reg(dev, reg + OFFS_REG_LED_ON, LED_FULL_ON_OFF);`
`200`	`203`	`}`