Sustainsys.Saml2.AspNetCore2.HttpRequestExtensions should be public

[magnusj64]

I would like to be able to call Sustainsys.Saml2.AspNetCore2.HttpRequestExtensions.ToHttpRequestData() from my code. As the similar function in the older Sustainsys.Saml2.HttpModule is defined in a public class I assume this omission is just an oversight.

As a workaround, I can copy this class into my own code without any issues. But I would prefer if I could use the existing code from the Sustainsys.Saml2.AspNetCore2 nuget .

[AndersAbel]

This looks like a reasonable change to do, yes. Would you like to submit a PR?

[magnusj64]

I made a PR for the v2 branch. Haven't checked if there's a need in the develop branch.

[rikrak]

One word of caution here: I copied the code for ToHttpRequestData() into my code base in order to access the relay data during the authentication process. I noticed an issue whereby, if the ToHttpRequestData() is called outside the scope of an authentication request, an exception can occur when posting a form. In my case, the exception occurred when posting a form that contained a checkbox. The form data contained two values for the same html element name. This caused this line[1] to blow up, as it assumes only a single value will be present for each form element.

        private void InitBasicFields(string httpMethod, Uri url, string applicationPath, IEnumerable<KeyValuePair<string, IEnumerable<string>>> formData)
        {
            HttpMethod = httpMethod;
            Url = url;
            ApplicationUrl = new Uri(url, applicationPath);
            Form = new ReadOnlyDictionary<string, string>(
                (formData ?? Enumerable.Empty<KeyValuePair<string, IEnumerable<string>>>())
                .ToDictionary(kv => kv.Key, kv => kv.Value.Single()));       /////  <--- HERE
            QueryString = QueryStringHelper.ParseQueryString(url.Query);
        }

Naturally this isn't a problem if the class is internal, as there is a great deal of control over where the method can be used. The restriction on where it's safe to use this method is not so obvious for a public class however. Obviously, the quick (and safe?) fix is to use .First() instead of .Single() (that's what I did in my copy of the method)

[1]

Saml2/Sustainsys.Saml2/WebSSO/HttpRequestData.cs

Line 170 in 3508193

.ToDictionary(kv => kv.Key, kv => kv.Value.Single()));