Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually installed extension doesn't add to source #1110

Closed
MC874 opened this issue Nov 10, 2024 · 8 comments
Closed

Manually installed extension doesn't add to source #1110

MC874 opened this issue Nov 10, 2024 · 8 comments
Labels
bug Something isn't working

Comments

@MC874
Copy link

MC874 commented Nov 10, 2024

PLEASE READ THIS

Device information

  • Suwayomi-Server version: v1.1.1-r1689-win64
  • Server Operating System: Windows 11 23H2 (OS Build 22631.4317)
  • Server Desktop Environment: N/A
  • Server JVM version: Bundled with Suwayomi Java 8.0.3920.8
  • Client Operating System: Windows 11 23H2 (OS Build 22631.4317)
  • Client Web Browser: Bundled Electron and Microsoft Edge 130.0.2849.80

Steps to reproduce

  1. Download APK extension from: https://github.com/keiyoushi/extensions/tree/repo/apk
  2. Inside Suwayomi: Browser -> Extensions -> Install external extension (+) -> Open extension (.apk)

Expected behavior

Extension is installed add added to source

Actual behavior

Extension is installed but not showing in source & can't be used as source

Other details

1
2

@MC874 MC874 added the bug Something isn't working label Nov 10, 2024
@Robonau
Copy link
Contributor

Robonau commented Nov 10, 2024

its filtered out by language

@MC874 MC874 changed the title Manually install extension doesn't add to source Manually installed extension doesn't add to source Nov 10, 2024
@MC874
Copy link
Author

MC874 commented Nov 10, 2024

its filtered out by language

The language is "All", still not showing

@Robonau
Copy link
Contributor

Robonau commented Nov 10, 2024

"All" is a language, its not all languages

@MC874
Copy link
Author

MC874 commented Nov 10, 2024

"All" is a language, its not all languages

Now works properly, thanks. It would be good to make it more clear to avoid confusion. And why also it's not showing as "other", is it also a language?
image

@Robonau
Copy link
Contributor

Robonau commented Nov 10, 2024

other is also a language yes, everything in that filter list is a language.
the language that sources have come from the extensions (the repo).
the defaults being english and local is all we do.

@MC874
Copy link
Author

MC874 commented Nov 10, 2024

other is also a language yes, everything in that filter list is a language. the language that sources have come from the extensions (the repo). the defaults being english and local is all we do.

Alright, it is confusing at first. But, I have a grasp on it now. Can I turn this into suggestion ticket? Or create a new one?

@Robonau
Copy link
Contributor

Robonau commented Nov 10, 2024

make a new one, you probably want to make it in the webui repo not the server one since thats what has the defaults

@MC874
Copy link
Author

MC874 commented Nov 10, 2024

make a new one, you probably want to make it in the webui repo not the server one since thats what has the defaults

Alright thank you, I'll close this now.

@MC874 MC874 closed this as completed Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants