#1164 fix select file error #1187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NA - Resolving Issues Involving Dependencies
…e robust path resolution, issue Swati4star#1164
…to 1164-fix-select-file-error
|
Code Climate has analyzed commit a0abf6e and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the issue about selecting PDF's on the reordering PDF page, when selecting from Recent or Documents section, as these directories were considered "external" and were "out of scope" due to scoped storage restrictions introduced with API 30+, this provides a more robust path resolution.
Dependencies were also changed to different sources and versions so that the project can run on any Android Studio import. This can be reverted if there have been changes made to this, or perhaps something just happened to go wrong when I tried importing this project myself.
Fixes #1164
Type of change
Just put an x in the [] which are valid.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
./gradlew assembleDebug assembleRelease./gradlew checkstyleChecklist: