Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom snapshot name isn't respected #180

Open
aaronpowell opened this issue Apr 21, 2023 · 0 comments
Open

Custom snapshot name isn't respected #180

aaronpowell opened this issue Apr 21, 2023 · 0 comments

Comments

@aaronpowell
Copy link
Contributor

Describe the bug
This is related to #178, as I was trying to work around the problem there by providing a custom name for the snapshot, but I found that even if you do provide a custom name the resolver is still called (where the bug in #178 is), nullifying the workaround. The offending line is here:

https://github.com/SwissLife-OSS/snapshooter/blob/master/src/Snapshooter/SnapshotFullNameResolver.cs#L69

To Reproduce

Expected behavior
The custom name to be used and no logic to attempt name generation is executed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant