Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compilation requires Makevars #1

Open
hadley opened this issue Apr 11, 2018 · 2 comments
Open

Compilation requires Makevars #1

hadley opened this issue Apr 11, 2018 · 2 comments

Comments

@hadley
Copy link

hadley commented Apr 11, 2018

PKG_CPPFLAGS=-DSTRICT_R_HEADERS

Otherwise R's realloc macro conflicts with the Realloc function in rapidjson

@SymbolixAU
Copy link
Collaborator

SymbolixAU commented Apr 12, 2018

Is that required for this package, or packages which depend on this?

For example, in my geojsonsf (dev only atm) I've specified the // [[Rcpp::depends(rapidjsonr)]] to appear before the call to #include <Rcpp.h> to get around the issue.

Whereas if I use your suggestion in the Makevars file there's no requirement for my solution.

@hadley
Copy link
Author

hadley commented Apr 12, 2018

I think it's required for all packages that depend on it. I couldn't get my package to compile without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant