Skip to content

Octoshock [PS1] movies require a cycle count for timing. #1878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Spikestuff opened this issue Mar 8, 2020 · 4 comments
Closed

Octoshock [PS1] movies require a cycle count for timing. #1878

Spikestuff opened this issue Mar 8, 2020 · 4 comments
Labels
Core: Nymashock Playstation (PSX/PS1) core Core: Octoshock Playstation (PSX/PS1) core Repro: Fixed/added in 2.8 Released 2022-02-19

Comments

@Spikestuff
Copy link

This is something I've been talking recently with @vadosnaprimer about this due to how there could be a change on how we handle dumping the core.
The times are vastly different when AVISync is in play or not for an NTSC game, a simple calculation of just using the framerate into amount of frames isn't cutting it anymore and apparently using cycle timing would correct the issues we're facing.

Some information that I found on cycle counts was over at ngemu.

  • Clock - 33.868800 MHz or 33,868,800 cycles/s
  • VSync - 59.94 Hz for NTSC or 565,045 cycles/vsync
  • CDROM 1x speed - 75 sectors/s or 451,584 cycles/sector
@YoshiRulz YoshiRulz added the Core: Octoshock Playstation (PSX/PS1) core label Mar 8, 2020
@Spikestuff
Copy link
Author

Spikestuff commented Sep 24, 2020

Oh right this was technically resolved... in a different younger tracker.

@vadosnaprimer
Copy link
Contributor

vadosnaprimer commented Jan 14, 2022

Looks like it's not resolved completely because there's discrepancy between values reported by mednafen and beetle on one side and bizhawk on the other.

[18:42:07] [feoss] zeromuisan: I noticed weird discrepancy between #2138 (comment) and 98b3d8d#diff-1f9d0430c31419724bf714c88c4cac87b3172cad8294b69ea1091d0450966c0cR140
[18:42:08] [feoss] natt reports it should be 59.8260456273 for 240p and 59.94 for 480i, but you set it to be 59.94006013870239 which seems to originate from mednafen code? aren't most psx games 240p? it's unclear what should be used for calculating movie length in real time
[00:04:09] [zeromuisan] i have nothing useful to add. if the times are different, then one time doesnt suffice. i would follow mednafen and insist that's good enough.

Since games can switch between 240p and 480i as they please, we can't use any constant fps value to determine the correct movie length once and for all. Then we have the core changing its fps on the fly, but that is resolved by audio sync in dumping, isn't it?

@vadosnaprimer vadosnaprimer reopened this Jan 14, 2022
@CasualPokePlayer
Copy link
Member

Nymashock implements ICycleTiming and reports a cycle count and clock rate accordingly.

@YoshiRulz YoshiRulz added Core: Nymashock Playstation (PSX/PS1) core Repro: Fixed/added in 2.8 Released 2022-02-19 labels Feb 3, 2022
@YoshiRulz YoshiRulz reopened this Feb 4, 2022
@Spikestuff
Copy link
Author

Soft closing mainly due to the eventual, real existing dropping of Octoshock.
Also because of current year-- and prior Octoshock hasn't been used compared to the domination of Nymashock.

@YoshiRulz YoshiRulz closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core: Nymashock Playstation (PSX/PS1) core Core: Octoshock Playstation (PSX/PS1) core Repro: Fixed/added in 2.8 Released 2022-02-19
Projects
None yet
Development

No branches or pull requests

4 participants