Use alert for form errors

Author: adrien1018

app/controllers/problems_controller.rb

@@ -85,6 +85,7 @@ def edit
   def create
     params[:problem][:compiler_ids] ||= []
     @problem = Problem.new(check_params())
+    @ban_compiler_ids = params[:problem][:compiler_ids].map(&:to_i).to_set
     respond_to do |format|
       if @problem.save
         format.html { redirect_to @problem, notice: 'Problem was successfully created.' }
@@ -98,6 +99,7 @@ def create
 
   def update
     params[:problem][:compiler_ids] ||= []
+    @ban_compiler_ids = params[:problem][:compiler_ids].map(&:to_i).to_set
     respond_to do |format|
       @problem.attributes = check_params()
       pre_ids = @problem.testdata_sets.collect(&:id)

app/views/articles/_form.html.erb

@@ -5,16 +5,7 @@
 <% end %>
 
 <%= nested_form_for(@article) do |f| %>
-  <% if @article.errors.any? %>
-    <div id="error_explanation">
-      <h2><%= pluralize(@article.errors.count, "error") %> prohibited this article from being saved:</h2>
-      <ul>
-        <% @article.errors.full_messages.each do |msg| %>
-          <li><%= msg %></li>
-        <% end %>
-      </ul>
-    </div>
-  <% end %>
+  <%= render partial: "shared/errors", locals: {errors: @article.errors, item: 'article'} %>
 
   <div class="form-group">
     <%= f.label :pinned, "Pin to top" %><br>

app/views/comments/_form.html.erb

@@ -3,16 +3,7 @@
   <% form_target = [@contest] + form_target %>
 <% end %>
 <%= form_for form_target do |f| %>
-  <% if @post.errors.any? %>
-    <div id="error_explanation">
-      <h4><%= pluralize(@post.errors.count, "error") %> prohibited this problem from being saved:</h4>
-      <ul>
-        <% @post.errors.full_messages.each do |msg| %>
-          <li><%= msg %></li>
-        <% end %>
-      </ul>
-    </div>
-  <% end %>
+  <%= render partial: "shared/errors", locals: {errors: @comment.errors, item: 'comment'} %>
 
   <div class="form-group">
     <%= f.label :title, "Title:" %><br />

app/views/contests/_form.html.erb

@@ -5,17 +5,7 @@
 <% end %>
 
 <%= nested_form_for(@contest) do |f| %>
-  <% if @contest.errors.any? %>
-    <div id="error_explanation">
-    <h2><%= pluralize(@contest.errors.count, "error") %> prohibited this contest from being saved:</h2>
-
-    <ul>
-      <% @contest.errors.full_messages.each do |msg| %>
-        <li><%= msg %></li>
-      <% end %>
-    </ul>
-    </div>
-  <% end %>
+  <%= render partial: "shared/errors", locals: {errors: @contest.errors, item: 'contest'} %>
 
   <div class="form-group">
     <%= f.label :title %>

app/views/judge_servers/_form.html.erb

@@ -1,15 +1,6 @@
 <%= form_for @judge_server do |f| %>
-  <% if @judge_server.errors.any? %>
-    <div id="error_explanation">
-      <h2><%= pluralize(@judge_server.errors.count, "error") %> prohibited this JudgeServer from being saved:</h2>
+  <%= render partial: "shared/errors", locals: {errors: @judge_server.errors, item: 'JudgeServer'} %>
 
-      <ul>
-        <% @judge_server.errors.full_messages.each do |msg| %>
-          <li><%= msg %></li>
-        <% end %>
-      </ul>
-    </div>
-  <% end %>
   <div class="form-group">
     <%= f.label :name, 'Server Name' %> <br>
     <%= f.text_field :name, :class => 'form-control', :placeholder => 'Server Name' %>
@@ -25,6 +16,4 @@
   <div class="form-group">
     <%= f.submit :class=>"btn btn-primary "%>
   </div>
-
-
 <% end %>

app/views/posts/_form.html.erb

@@ -8,16 +8,7 @@
 
 <% form_target = @postable ? [@postable, @post] : @post %>
 <%= form_for form_target do |f| %>
-  <% if @post.errors.any? %>
-    <div id="error_explanation">
-      <h4><%= pluralize(@post.errors.count, "error") %> prohibited this problem from being saved:</h4>
-      <ul>
-        <% @post.errors.full_messages.each do |msg| %>
-          <li><%= msg %></li>
-        <% end %>
-      </ul>
-    </div>
-  <% end %>
+  <%= render partial: "shared/errors", locals: {errors: @post.errors, item: 'post'} %>
 
   <div class="form-group">
     <%= f.label :title, "Title:" %> <br />

app/views/problems/_form.html.erb

@@ -5,16 +5,7 @@
 <% end %>
 
 <%= nested_form_for @problem, :html => {:class => 'form', :id => 'problem-form'} do |f| %>
-  <% if @problem.errors.any? %>
-    <div id="error_explanation">
-      <h2><%= pluralize(@problem.errors.count, "error") %> prohibited this problem from being saved:</h2>
-      <ul>
-        <% @problem.errors.full_messages.each do |msg| %>
-          <li><%= msg %></li>
-        <% end %>
-      </ul>
-    </div>
-  <% end %>
+  <%= render partial: "shared/errors", locals: {errors: @problem.errors, item: 'problem'} %>
 
   <div class="row">
     <div class="col-md-12">

app/views/shared/_errors.html.erb

@@ -0,0 +1,10 @@
+<% if errors.any? %>
+  <div id="error_explanation" class="alert alert-danger" role="alert">
+    <strong><%= pluralize(errors.count, "error") %> prohibited this <%= item %> from being saved:</strong>
+    <ul>
+      <% errors.full_messages.each do |msg| %>
+        <li><%= msg %></li>
+      <% end %>
+    </ul>
+  </div>
+<% end %>

app/views/submissions/_form.html.erb

@@ -4,16 +4,7 @@
   <% set_page_title "New Submission - " + @problem.id.to_s + " - " + @problem.name %>
 <% end %>
 <%= form_for [@problem, @submission] do |f| %>
-  <% if @submission.errors.any? %>
-    <div id="error_explanation">
-      <h2><%= pluralize(@submission.errors.count, "error") %> prohibited this submission from being saved:</h2>
-      <ul>
-      <% @submission.errors.full_messages.each do |msg| %>
-        <li><%= msg %></li>
-      <% end %>
-      </ul>
-    </div>
-  <% end %>
+  <%= render partial: "shared/errors", locals: {errors: @submission.errors, item: 'submission'} %>
 
   <div class="form-group">
     <%= render 'compiler_chooser', :f => f %>

app/views/testdata/_form.html.erb

@@ -1,14 +1,5 @@
 <%= form_for [@problem, @testdatum], :html => {:multipart => true} do |f| %>
-  <% if @testdatum.errors.any? %>
-    <div id="error_explanation">
-      <h2><%= pluralize(@testdatum.errors.count, "error") %> prohibited this testdatum from being saved:</h2>
-      <ul>
-        <% @testdatum.errors.full_messages.each do |msg| %>
-        <li><%= msg %></li>
-        <% end %>
-      </ul>
-    </div>
-  <% end %>
+  <%= render partial: "shared/errors", locals: {errors: @testdatum.errors, item: 'testdatum'} %>
 
   <div class="form-group">
     <%= f.label :test_input, "input testdata" %><br>