Fix migration

Author: adrien1018

…0306071028_add_discription_to_contest.rb …0306071028_add_description_to_contest.rbdb/migrate/20230306071028_add_discription_to_contest.rb renamed to db/migrate/20230306071028_add_description_to_contest.rb db/migrate/20230306071028_add_discription_to_contest.rb renamed to db/migrate/20230306071028_add_description_to_contest.rb

@@ -1,4 +1,4 @@
-class AddDiscriptionToContest < ActiveRecord::Migration[7.0]
+class AddDescriptionToContest < ActiveRecord::Migration[7.0]
   def change
     add_column :contests, :description_before_contest, :mediumtext
     Contest.update_all("description_before_contest = description")

db/migrate/20230306110102_migrate_old_results.rb

@@ -1,48 +1,64 @@
 class MigrateOldResults < ActiveRecord::Migration[7.0]
-  def up
-    Submission.where(contest_id: nil).where.not(old_result: nil).find_in_batches do |lst|
-      data = lst.map {|s|
-        {
-          submission_id: s.id,
-          problem_id: s.problem_id,
-          result: s.old_result,
-          score: s.old_score,
-          time: s.old_time,
-          memory: s.old_memory,
-        }
-      }
-      OldSubmission.import(data)
-    end
-    mp = OldSubmission.pluck(:submission_id, :id).to_h
-    mp.values.each_slice(256).each {|lst|
-      data = SubmissionTask.where(submission_id: lst).where.not(old_result: nil).map { |s|
-        {
-          old_submission_id: mp[s.submission_id],
-          position: s.position,
-          result: s.old_result,
-          score: s.old_score,
-          time: s.old_time,
-          memory: s.old_memory,
-        }
-      }
-      OldSubmissionTask.import(data)
-    }
-    
-    add_index :old_submissions, [:problem_id, :result]
+  def change
     remove_index :submissions, [:contest_id, :new_rejudged, :result]
     remove_index :submissions, [:contest_id, :new_rejudged, :id]
     remove_index :submissions, [:contest_id, :user_id, :problem_id, :old_result], name: :index_submissions_old_user_query
     remove_index :submissions, [:contest_id, :user_id, :result, :old_result], name: :index_submissions_old_user_result
     remove_index :submissions, [:contest_id, :user_id, :result, :old_result, :problem_id], name: :index_submissions_old_user_problem_result
-    remove_column :submission_tasks, :old_result
-    remove_column :submission_tasks, :old_score
-    remove_column :submission_tasks, :old_time
-    remove_column :submission_tasks, :old_memory
-    remove_column :submissions, :old_result
-    remove_column :submissions, :old_score
-    remove_column :submissions, :old_time
-    remove_column :submissions, :old_memory
-    remove_column :submissions, :new_rejudged
-    remove_column :problems, :old_pid
+
+    reversible do |direction|
+      direction.up do
+        execute %{
+          INSERT INTO old_submissions
+            (submission_id, problem_id, result, score, time, memory, created_at, updated_at)
+          SELECT id, problem_id, old_result, old_score, old_time, old_memory, NOW(), NOW()
+          FROM submissions
+          WHERE contest_id IS NULL AND old_result IS NOT NULL
+        }
+        execute %{
+          INSERT INTO old_submission_tasks
+            (old_submission_id, position, result, score, time, memory, created_at, updated_at)
+          SELECT old_submissions.id, submission_tasks.position, submission_tasks.old_result,
+                 submission_tasks.old_score, submission_tasks.old_time, submission_tasks.old_memory, NOW(), NOW()
+          FROM submission_tasks
+          INNER JOIN old_submissions ON submission_tasks.submission_id = old_submissions.submission_id
+          WHERE submission_tasks.old_result IS NOT NULL
+        }
+      end
+      direction.down do
+        execute %{
+          UPDATE submissions,
+            (SELECT submission_id, result, score, time, memory FROM old_submissions) AS t
+          SET submissions.old_result = t.result, submissions.old_score = t.score,
+              submissions.old_time = t.time, submissions.old_memory = t.memory
+          WHERE submissions.id = t.submission_id
+        }
+        execute %{
+          UPDATE submission_tasks,
+            (SELECT old_submissions.submission_id, old_submission_tasks.position,
+                    old_submission_tasks.result, old_submission_tasks.score,
+                    old_submission_tasks.time, old_submission_tasks.memory
+             FROM old_submission_tasks
+             INNER JOIN old_submissions ON old_submissions.id = old_submission_tasks.old_submission_id
+            ) AS t
+          SET submission_tasks.old_result = t.result, submission_tasks.old_score = t.score,
+              submission_tasks.old_time = t.time, submission_tasks.old_memory = t.memory
+          WHERE submission_tasks.submission_id = t.submission_id AND
+                submission_tasks.position = t.position
+        }
+      end
+    end
+
+    add_index :old_submissions, [:problem_id, :result]
+    remove_column :submission_tasks, :old_result, :string
+    remove_column :submission_tasks, :old_score, :decimal, precision: 18, scale: 6
+    remove_column :submission_tasks, :old_time, :integer
+    remove_column :submission_tasks, :old_memory, :integer
+    remove_column :submissions, :old_result, :string
+    remove_column :submissions, :old_score, :decimal, precision: 18, scale: 6
+    remove_column :submissions, :old_time, :integer
+    remove_column :submissions, :old_memory, :integer
+    remove_column :submissions, :new_rejudged, :boolean
+    remove_column :problems, :old_pid, :integer
   end
 end