1291 split view progress bar in wrong position after entering fullscreen mode if the width ratio of two views adjusted #1393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le press on player so the fullscreen won't break
|
Your Testserver will be ready at https://1393.test.live.mm.rbg.tum.de in a few minutes. Logins
|
This one and only side effect is irrelevant imo and as far as I can tell, but I my have missed something. I'd guess, that there was a reason for choosing the non-straight-forward solution of making the right control bar the main control bar, but I haven't found anything plausible yet. This may be on me though. If anyone knows more, let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
See Issue #1291.
Description
Adjusting size of players in splitview when in fullscreen mode (or vice versa) doesn't result in the control bar being in the wrong position anymore. This applies to subtitles as well.
Currently, the control bar of the right video player is used as the control bar for both video players, the one on the left is hidden. This results in said weird issues as the control bar has to have (potentially high) negative left margins. As I couldn't figure out what exactly is the issue with updating the left margin, this is fixed by switching roles of the two control bars (left is "global" control bar, right is hidden). This may have side effects! Only side effect known to me is that the subtitle settings menu is now an overlay of the left video player (instead of the right player).
Steps for Testing
Prerequisites: