Search Box to search for courses, streams and subtitles #1380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karjo24
reviewed
Sep 30, 2024
CommanderStorm
requested changes
Oct 7, 2024
There was a problem hiding this comment.
Hi, you were likely not expecting a review from me, but @joschahenningsen told me that meilisearch is happening and I thought that looking over the usage might be benefitial.
This is an incredibly large PR.
Reviewing this is impossible, anybody who tells you that they reviewed it is likely lying on at least some part.
=> Please in the future split your PRs way before the +2,513 lines mark.
karjo24
reviewed
Oct 10, 2024
Co-authored-by: Frank Elsinga <[email protected]>
|
From my point of view, there is nothing left to review. |
@CommanderStorm Thanks for your review and suggestions, it was much appreciated! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This Change solves the problem of finding lectures in a large list of lectures. It also enhances the search for subtitles or streams in courses.
Closes #1337.
Description
The change adds a search bar at the top of every page where you can search for courses or contents of a course, depending if you're on a course page or on the home page.
Steps for Testing
You can't test this change on the Testserver system.
You have to set up your own local instance of TUM-Live for testing and also have to setup your own meilisearch service.
To start the meilisearch service, you can run the following command:
docker run -it --rm \ -p 7700:7700 \ -e MEILI_MASTER_KEY='MASTER_KEY'\ -v $(pwd)/meili_data:/meili_data \ getmeili/meilisearch:v1.9 \ meilisearch --env="development"If the data isn't automatically exported to meilisearch, you can run this job from the
MaintenanceTab in the Admin panel.You can enter your search query in the search bar on every page or you can press 'Enter' while the search bar is focused to see the full search page with filters etc.