[BUGFIX] Prevent settings spill-over in cached context (#419)

jonaseberle · mbrodala · commit 60545b6cbb6d · 2018-11-16T15:07:17.000+01:00
diff --git a/src/Core/ViewHelper/AbstractTagBasedViewHelper.php b/src/Core/ViewHelper/AbstractTagBasedViewHelper.php
@@ -88,6 +88,9 @@ public function initializeArguments()
     public function initialize()
     {
         parent::initialize();
+        $this->tag->reset();
+        $this->tag->setTagName($this->tagName);
+
         if ($this->hasArgument('additionalAttributes') && is_array($this->arguments['additionalAttributes'])) {
             $this->tag->addAttributes($this->arguments['additionalAttributes']);
         }

Original file line number	Diff line number	Diff line change
`@@ -88,6 +88,9 @@ public function initializeArguments()`
`88`	`88`	`public function initialize()`
`89`	`89`	`{`
`90`	`90`	`parent::initialize();`
	`91`	`+ $this->tag->reset();`
	`92`	`+ $this->tag->setTagName($this->tagName);`
	`93`	`+`
`91`	`94`	`if ($this->hasArgument('additionalAttributes') && is_array($this->arguments['additionalAttributes'])) {`
`92`	`95`	`$this->tag->addAttributes($this->arguments['additionalAttributes']);`
`93`	`96`	`}`