Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installing update of SuperTool requires restart of Gramps #36

Open
emyoulation opened this issue Jul 14, 2024 · 3 comments
Open

installing update of SuperTool requires restart of Gramps #36

emyoulation opened this issue Jul 14, 2024 · 3 comments
Assignees
Labels
documentation Improvements or additions to documentation SuperTool

Comments

@emyoulation
Copy link
Contributor

I had SuperToo1 1.4.7 installed and was using it in the session. But closed it and used the Addon Manager to update to the 1.4.8 version. However, the 1.4.7 version continued to run until restarting Gramps.

I wonder if the Addon Manager needs to re-run the Plugin Registration after a successful addon update. (Which still would not allow views to update since the GUI has that data cached. And features using dialogs in the Windows menu would likewise be locked.)

@emyoulation
Copy link
Contributor Author

Not an Isotammi responsibility to correct... just thought you'd want to be aware.

@kkujansuu
Copy link
Contributor

This is probably because the Supertool.py module is loaded at Gramps startup. Therefore all the classes in the module remain in memory even if the code on disk is updated and the tool itself is closed.

This behaviour changed at a recent version when I introduced the "supertool_execute" function. This function requires that the Supertool code is always available.

It might be possible to fix this but maybe it's not worth the effort.

@emyoulation
Copy link
Contributor Author

I agree that it is probably not worth effort to resolve. But publicly documenting the behavior could set expectations instead.

@kkujansuu kkujansuu added the documentation Improvements or additions to documentation label Jul 14, 2024
@kkujansuu kkujansuu self-assigned this Jul 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation SuperTool
Projects
None yet
Development

No branches or pull requests

2 participants