Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SuperTool Generic filter rules field label inconsistency #9

Open
emyoulation opened this issue Sep 16, 2022 · 0 comments
Open

SuperTool Generic filter rules field label inconsistency #9

emyoulation opened this issue Sep 16, 2022 · 0 comments

Comments

@emyoulation
Copy link
Contributor

emyoulation commented Sep 16, 2022

While updating the Generic filter rule wiki documentation on Gramps-Project.com, noted that the labels in the Generic filter rules do not directly match the SuperTool field labels.

Suggestions:

  • In the "Generic filter rules", rename to eliminate the words "filter" & "rule"as these are implicitly Rules and explicitly not custom filters. How about "Generic query"? And if (and only if) the rules call the SuperTool engine namespaces differently for each category, insert the Category/Namespace in the name. This would make their appearance in the FilterParams interface less ambiguous. e.g., the Person category "Generic filter rule" label could evolve to become "Person query".
  • There is no "Invert" in any the Generic filter rules. Should an Invert option be included?
  • The "Generic filter rule" Values fields are "Rule:", "Initial statements:" and "Statements:". But the SuperTool has "Title:", "Initialization statements:", "Statements executed for each object:", "Filter: Expressions to display:" It would be less ambiguous if the field that correspond in these 2 dialogs have matching labels. (This also decreases the number of Weblate terms to translate.)
  • The limited width of the Add Rule GUI makes putting the label and value field on consecutive rows (perhaps having 3 rows for each Statement value field.

image

@emyoulation emyoulation changed the title SuperTool Gener filter rules field label inconsistency SuperTool Generic filter rules field label inconsistency Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants