Allow onSuccess to be async, causing isLoading to wait for resolution

[jtparrett]

As far as I can tell, this isn't a thing currently.

But it would be really handy if onSuccess could accept an async function which will be awaited before isLoading is set to true.

Alternatively a new onAsyncSuccess(terrible name) option might be simpler to implement.

[TkDodo]

But it would be really handy if onSuccess could accept an async function which will be awaited before isLoading is set to true.

you mean before isLoading is set to false? Anyways, what problem are you trying to solve please?

[jtparrett]

Yes, isLoading set to false sorry!

It's not for a specific issue, although the case I attempted to use it in and realised it wasn't a thing looked a little like this:

const createPost = useMutation(
  (values) => api.post('/create-post', values),
  {
    async onSuccess(){
      await queryClient.refetchQueries(['allPosts']);
    }
  }
)

and so you would perform the mutation, and it would await the refetch before createPost.isLoading is set to false.

[TkDodo]

Okay, you are talking about useMutation and not useQuery. onSuccess is async for useMutation for this exact reason.

[jtparrett]

Wow. I am so sorry for wasting your time. I’m just not gunna go on the internet for a little while 🤦🏻