useErrorBoundary function: accept query state as a second parameter

[chrisvasz]

I have a situation where I want to throw to an error boundary if the query fails. BUT, if the app is offline, I want to render any cached data even if the query is currently failing due to any number of offline conditions. Right now, I'm having to define this functionality in every query config object. I would like to be able to define it globally. My proposal is to add the query state as another parameter to the useErrorBoundary function.

Here's what I'm doing now:

// individual query config
{
  queryKey: key,
  queryFn: () => fetch(...key),
  useErrorBoundary: () => {
    const state = queryClient.getQueryState(key);
    if (!state) return true;
    // if we have cached data, use it instead of showing any number of offline error conditions
    if (isOffline()) return state.data === undefined; 
    return true;
  },
};

Here's what I would like to be able to do (or something like it):

// global config
{
  useErrorBoundary: (error, queryState) => {
    if (isOffline()) return queryState.data === undefined;
    return true;
  },
}

// individual query config
{
  queryKey: key,
  queryFn: () => fetch(...key),
}

[TkDodo]

Like this open PR?
#2660

[chrisvasz]

🤦‍♂️ indeed, exactly like that open PR, ha. Thanks!

[chrisvasz]

Is anything holding that PR back? Looks like it's been open for about 5 months with no activity.

[TkDodo]

I opened it but didn't want to rush it if it's not needed. Some internals are a bit weird, I have to take a look at it again :)

[chrisvasz]

Thanks for getting that one merged!