Replies: 1 comment
-
Thanks for bringing that up. For now we know at the very least that with RT, you can always override the props, including the key, so it wouldn't need to be a breaking change. In the future, we'll definitely stop doing this and just supply a unique ID to use as the key instead (I am already doing this in the |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
So when I was migrating to typescript 3.9 I encountered various compiler error relating to the overwriting of key props (unreleated, but annoying), which brough to my attention the fact that react-table supplies a
key
prop in its most if not all of its get props functions. I believe that you might need to rethink this design as passing a key via props spreading might become depecrated in future versions of react:https://github.com/reactjs/rfcs/blob/createlement-rfc/text/0000-create-element-changes.md
Beta Was this translation helpful? Give feedback.
All reactions