Found overflow condition in pump control

Rishi Sharma · Rishi Sharma · commit 6ffaac5f4296 · 2019-04-03T07:05:41.000-05:00
diff --git a/libraries/PumpControl/PumpControl.h b/libraries/PumpControl/PumpControl.h
@@ -5,8 +5,8 @@
 
 #define FLOW_TOTAL_LENGTH_TIME_A 1000
 #define FLOW_TOTAL_LENGTH_TIME_B 1000
-#define UNIT_OF_LIQUID_A 12500
-#define UNIT_OF_LIQUID_B 18518
+#define UNIT_OF_LIQUID_A 12500UL
+#define UNIT_OF_LIQUID_B 18518UL // MUST BE AT LEAST LONG ELSE OVERFLOW
 
 class PumpControl
 {

Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,8 @@`
`5`	`5`
`6`	`6`	`#define FLOW_TOTAL_LENGTH_TIME_A 1000`
`7`	`7`	`#define FLOW_TOTAL_LENGTH_TIME_B 1000`
`8`		`-#define UNIT_OF_LIQUID_A 12500`
`9`		`-#define UNIT_OF_LIQUID_B 18518`
	`8`	`+#define UNIT_OF_LIQUID_A 12500UL`
	`9`	`+#define UNIT_OF_LIQUID_B 18518UL // MUST BE AT LEAST LONG ELSE OVERFLOW`
`10`	`10`
`11`	`11`	`class PumpControl`
`12`	`12`	`{`