trying to figure out runtime lists

[emaayan]

so i'm trying to create a timezone selection menu where one would selected a country then a city for timezone offset
i would do the same for GPS coordinates
the problems is i can't figure out how to actually create the lists.. i mean assume i have an array of struct i've generated from a pre-made list how would i attach it to the menu
i kept reading the docs, but they seem a little out of sync, like for example the initial raw field doesn't appear in the generator, i thought i would enter that number, and the callback woudl be used for each row to fill out it's name and value.

[davetcc]

So when working with lists, there's a couple of steps, first, once the menu item is generated it will put a "renderFn" into your INO sketch. This will be called whenever anything happens on the list. You can read about that here - https://www.thecoderscorner.com/products/arduino-libraries/tc-menu/menu-item-types/list-menu-item/

But in short, during setup or when the number of items changes, you set the number of items on the list, then as the list is drawn, it will call the render function to get the name and value for each item. The name appears on the left, the value on the right. The title is a special row, it is the row numbered LIST_PARENT_ITEM_POS and whatever text is returned from the render function for that row will be the text for the title and back button.

About the clearest example for how you intend to use it could be - https://github.com/davetcc/tcMenuLib/blob/master/examples/esp/esp32Amplifier/esp32Amplifier.ino#L187

[emaayan]

thanks, a little bit clearer now, but where do you place the set the number of items on list? (not sure what you mean during setup, cause i have no access to initialRows value in the generator

[davetcc]

You do it in your code, at whatever point you know how many rows you have. I'm assuming during setup or some point later you'd know. For example, if the list was called "MyList" and there were 10 items in the list, you would call.

menuMyList.setNumberOfRows(10);

[emaayan]

you mean somewhere in my callback cause that's the only place i have access to myMenuList

int CALLBACK_FUNCTION fnSetTimeZoneListRtCall(RuntimeMenuItem *item, uint8_t row, RenderFnMode mode, char *buffer, int bufferSize)
{
    const bool isTitle = row == LIST_PARENT_ITEM_POS;
    switch (mode)
    {
    case RENDERFN_INVOKE:
        // item->setNumberOfRows(10);
        //  TODO - your code to invoke goes here - row is the index of the item
        if (isTitle){
            item->setNumberOfRows(10);
        }
        
        if (!isTitle && renderer.getDialog() && !renderer.getDialog()->isInUse())
        {
         
            renderer.getDialog()->setButtons(BTNTYPE_NONE, BTNTYPE_CLOSE);
            renderer.getDialog()->showRam("List select", false);
            char sz[10];
            ltoaClrBuff(sz, row, 3, NOT_PADDED, sizeof sz);
            renderer.getDialog()->copyIntoBuffer(sz);
        }
        return true;
    case RENDERFN_NAME:
        if (isTitle)
        {
            strcpy(buffer, "TimeZones");
        }
        else
        {
            strncpy(buffer, "ISR", bufferSize);
            ltoaClrBuff(buffer, row, 3, NOT_PADDED, bufferSize);
        }
        return true;
    case RENDERFN_VALUE:
        if (isTitle)
        {
            strcpy(buffer, ">>");
        }
        else
        {
            strncpy(buffer, "Israel", bufferSize);
            fastltoa(buffer, row, 3, NOT_PADDED, bufferSize);
        }
        return true;
    case RENDERFN_EEPROM_POS:
        return 0xffff; // lists are generally not saved to EEPROM
    default:
        // return textItemRenderFn(item, row, mode, buffer, bufferSize); // pass thru to default
        return false;
    }

[davetcc]

No, you always have access to all menu items, take a look at the file yourProjectName_menu.h in your project, it exports every menu item as a global. You can use them anywhere.

For example a snippet from picoAdafruitDashboard_menu.h -

extern BooleanMenuItem menuSettingsCheckBox;
extern BooleanMenuItem menuSettingsYesNo;
extern Rgb32MenuItem menuSettingsRGB;
... more definitions

[davetcc]

End of the day it depends how often you intend to update that item.

For me the best solution is https://www.thecoderscorner.com/electronics/microcontrollers/psu-control/detecting-power-loss-in-powersupply/

The second best is to have a timer that checks if anything needs saving every N minutes and then does the save.

The third best is a save menu option on the menu (and I've often for simple stuff just gone with this as it is so simple).

[emaayan]

End of the day it depends how often you intend to update that item.

For me the best solution is https://www.thecoderscorner.com/electronics/microcontrollers/psu-control/detecting-power-loss-in-powersupply/

The second best is to have a timer that checks if anything needs saving every N minutes and then does the save.

The third best is a save menu option on the menu (and I've often for simple stuff just gone with this as it is so simple).

but the thing is , i don't plan on this menu being called often, infact i plan on it being called maybe only once during the device operation, because the entire menu shouldn't be active in the first.. the primary functon of the device is to display a clock and hebrew festivals dates which require the user to input timezones and location, so i figured i could have both in one shot in a config menu that will be saved once they select the proper location and be done with it.
that's why i figured the commit would be a good candidate.

[davetcc]

Agreed, if it has a low rate of change and you're using the commit callback, which only fires when the editing ends, then it should be quite safe as long as it's not edited many times a day or something.

[emaayan]

the problem is that neither onCommit seems to getCalled on any menu change

and all the methods except for menuEditEnded for MyObserver
they also don't seem to get called for any of my runtime addedMenu
and my original intention was to have menduEditEnded get Called on a runtimeMenuItemSelection

void onCommit(int menuId)
{

    if (menuCountry.getId() == menuId)
    {
        // Serial.print(menuId);
        const char *ctr = saveCountry();
        loadMenuCity(ctr);
    }
    if (menuCity.getId() == menuId)
    {
    }
}

class MyObserver : public MenuManagerObserver
{
public:
    void structureHasChanged() override
    {
    }

    bool menuEditStarting(MenuItem *item) override
    {

        return true; // allow editing to start
    }

    void menuEditEnded(MenuItem *item) override
    {
        menuid_t menuId = item->getId();
        if (menuCountry.getId() == menuId)
        {
            // Serial.print(menuId);
            const char *ctr = saveCountry();
            loadMenuCity(ctr);
        }
        if (menuCity.getId() == menuId)
        {
        }
    }

    void activeItemHasChanged(MenuItem *newActive) override
    {
        menuid_t menuId = newActive->getId();
        if (menuCountry.getId() == menuId)
        {
        }
    }

} myObserver;

void initSystem()
{

    status status = loadCountries();
    if (status.code > 0)
    {

        u_int32_t initConf = loadInit();
        loadCountry();
        setupMenu();

       
        const size_t totalCountries = countries.as<JsonArray>().size();
        menuCountry.setNumberOfRows(totalCountries);
         menuMgr.addChangeNotification(&myObserver);
      //  menuMgr.setItemCommittedHook(&onCommit);
        //  renderer.takeOverDisplay(myDisplayCallback);
    }
    else
    {
        writeError("Error %s", status.error);
    }
}

void setup()
{
    Serial.begin(115200);
    initDisplay();

    if (!LITTLEFS.begin(false))
    {
        writeError("%s", "LITTLEFS Mount Failed");
        return;
    }
    else
    {
        initSystem();
    }
}

[davetcc]

please raise another discussion, think about others trying to search for solutions later, there are several problems already in here.

[emaayan]

it this relevant for runtimeMenuItem as well?

…

On Sun, May 7, 2023 at 2:01 PM Dave Cherry ***@***.***> wrote: If it is menu state, you can either use the built in tcMenu save and load functions if they work for you - https://www.thecoderscorner.com/products/arduino-libraries/tc-menu/menu-eeprom-integrations/ There are a few possible strategies on how to save discussed on that page, but never call save during the callback invoke method, you'll destroy the ROM in days, they are measured in thousands of cycles. Given that, once you've configured a ROM in code generator, it would be as easy as menuMgr.save() in the right place. If you wanted to save custom data, you could use the helper that is available from menuMgr.getEepromAbstraction(), it is a pointer to the EEPROM you configured from code generator - https://www.thecoderscorner.com/products/arduino-libraries/io-abstraction/eeprom-impl-seamless-8-and-32-bit/ — Reply to this email directly, view it on GitHub <#335 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADGP5MGQTJTRNAR3QIVSVY3XE56I5ANCNFSM6AAAAAAXAK6CSM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[davetcc]

Anything that has an EEPROM location in the designer will save to EEPROM if the location is not -1.