Skip to content

Conversation

@dustdfg
Copy link
Contributor

@dustdfg dustdfg commented Jan 9, 2026

What is it?

  • Codebase improvement (dev facing)

Description of the changes in your PR

  • Convert settings migration logic to kotlin

APK testing

The APK can be found by going to the "Checks" tab below the title. On the left pane, click on "CI", scroll down to "artifacts" and click "app" to download the zip file which contains the debug APK of this PR. You can find more info and a video demonstration on this wiki page.

Due diligence

  • I read the contribution guidelines.
  • The proposed changes follow the AI policy.
  • $${\color{red}NO AT ALL, BASICALLY CAN'T}$$ I tested the changes using an emulator or a physical device.

@github-actions github-actions bot added the size/giant PRs with more than 750 changed lines label Jan 9, 2026
Copy link
Member

@theimpulson theimpulson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N O A T A L L , B A S I C A L L Y C A N ′ T I tested the changes using an emulator or a physical device.

Please don't open PRs blindly without adequate testing.

@dustdfg
Copy link
Contributor Author

dustdfg commented Jan 19, 2026

N O A T A L L , B A S I C A L L Y C A N ′ T I tested the changes using an emulator or a physical device.

Please don't open PRs blindly without adequate testing.

I'd like to test but I can't test it without having prepopulated dbs

@dustdfg dustdfg closed this Jan 19, 2026
@TobiGr
Copy link
Contributor

TobiGr commented Jan 19, 2026

Don't we have database migration tests? They seem to be fine.

@dustdfg
Copy link
Contributor Author

dustdfg commented Jan 19, 2026

Don't we have database migration tests? They seem to be fine.

DB migration while this PR is about settings migration...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/giant PRs with more than 750 changed lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants