Apply review suggestions

lm41 · lm41 · commit 57d1539f1415 · 2025-08-24T17:22:06.000+02:00
diff --git a/new-player/src/main/java/net/newpipe/newplayer/ui/selection_ui/StreamSelectUI.kt b/new-player/src/main/java/net/newpipe/newplayer/ui/selection_ui/StreamSelectUI.kt
@@ -122,7 +122,7 @@ internal fun ReorderableStreamItemsList(
                     playlistItem = playlistItem,
                     onClicked = {
                         if (!uiState.uiMode.isStreamSelect) {
-                            // We don't select the chapter when we are not in stream select mode
+                            // We don't select the stream when we are not in stream select mode
                             return@StreamItem
                         }
                         viewModel.streamSelected(index)
diff --git a/new-player/src/main/java/net/newpipe/newplayer/ui/videoplayer/VideoPlayerUI.kt b/new-player/src/main/java/net/newpipe/newplayer/ui/videoplayer/VideoPlayerUI.kt
@@ -131,7 +131,6 @@ internal fun VideoPlayerUi(viewModel: InternalNewPlayerViewModel, uiState: NewPl
             viewModel, uiState = uiState
         )
 
-        // Disable this animation as it induces ghost tabs
         AnimatedVisibility(visible = uiState.uiMode.isStreamSelect) {
             Surface(
                 modifier = Modifier.fillMaxSize(),
@@ -145,7 +144,6 @@ internal fun VideoPlayerUi(viewModel: InternalNewPlayerViewModel, uiState: NewPl
             }
         }
 
-        // Disable this animation as it induces ghost tabs
         AnimatedVisibility(visible = uiState.uiMode.isChapterSelect) {
             Surface(
                 modifier = Modifier.fillMaxSize(),

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ internal fun ReorderableStreamItemsList(`
`122`	`122`	`playlistItem = playlistItem,`
`123`	`123`	`onClicked = {`
`124`	`124`	`if (!uiState.uiMode.isStreamSelect) {`
`125`		`- // We don't select the chapter when we are not in stream select mode`
	`125`	`+ // We don't select the stream when we are not in stream select mode`
`126`	`126`	`return@StreamItem`
`127`	`127`	`}`
`128`	`128`	`viewModel.streamSelected(index)`
Original file line number	Diff line number	Diff line change
`@@ -131,7 +131,6 @@ internal fun VideoPlayerUi(viewModel: InternalNewPlayerViewModel, uiState: NewPl`
`131`	`131`	`viewModel, uiState = uiState`
`132`	`132`	`)`
`133`	`133`
`134`		`- // Disable this animation as it induces ghost tabs`
`135`	`134`	`AnimatedVisibility(visible = uiState.uiMode.isStreamSelect) {`
`136`	`135`	`Surface(`
`137`	`136`	`modifier = Modifier.fillMaxSize(),`
`@@ -145,7 +144,6 @@ internal fun VideoPlayerUi(viewModel: InternalNewPlayerViewModel, uiState: NewPl`
`145`	`144`	`}`
`146`	`145`	`}`
`147`	`146`
`148`		`- // Disable this animation as it induces ghost tabs`
`149`	`147`	`AnimatedVisibility(visible = uiState.uiMode.isChapterSelect) {`
`150`	`148`	`Surface(`
`151`	`149`	`modifier = Modifier.fillMaxSize(),`