Skip to content

search argument count #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
houzefa-abba opened this issue Jun 10, 2024 · 2 comments
Open

search argument count #4

houzefa-abba opened this issue Jun 10, 2024 · 2 comments

Comments

@houzefa-abba
Copy link

Since odoo/odoo@7e6cff5#diff-7144f88ea32f36feb17ce1b8dda7dee1631f5ada34075414587df3948c6b3d1bR1477 the search method takes 1 less argument

This code uses lots of patterns such as :

            if self.execute_odoo('ir.model.data', 'search',
                                 [[('module', '=', module), ('name', '=', name)], 0, 0, "id", False],
                                 {'context': config_context}):

which aside from missing some abstraction layers, send offset/limit/etc arguments as positional instead of sending them as keywords; whereas Odoo defines them as keyword arguments.

The last one, False in this case, has been removed in Odoo 17

These code patterns need rework, and at the very least False has to be removed for compat with Odoo 17

@myrrkel
Copy link
Contributor

myrrkel commented Jun 11, 2024

This is fixed here: https://github.com/ScalizerOrg/odoo-configurator

@houzefa-abba
Copy link
Author

This is fixed here: https://github.com/ScalizerOrg/odoo-configurator

Perfect thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants