[FIX] product_variant_route_mto: rely on product_route_mto

that relies on stock_route_mto

Author: jbaudoux

product_variant_route_mto/__manifest__.py

@@ -1,4 +1,5 @@
 # Copyright 2023 Camptocamp SA
+# Copyright 2025 Jacques-Etienne Baudoux (BCIM) <[email protected]>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
 
 {
@@ -9,10 +10,10 @@
     "category": "Inventory",
     "website": "https://github.com/OCA/product-attribute",
     "author": "Camptocamp SA, Odoo Community Association (OCA)",
-    "maintainers": ["mmequignon"],
+    "maintainers": ["mmequignon", "jbaudoux"],
     "license": "AGPL-3",
     "installable": True,
     "auto_install": False,
-    "depends": ["stock"],
+    "depends": ["product_route_mto"],
     "data": ["views/product_product.xml"],
 }

product_variant_route_mto/models/product_product.py

@@ -1,7 +1,9 @@
 # Copyright 2023 Camptocamp SA
+# Copyright 2025 Jacques-Etienne Baudoux (BCIM) <[email protected]>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
 
 from odoo import api, fields, models
+from odoo.exceptions import ValidationError
 
 IS_MTO_HELP = """
     Check or Uncheck this field to enable the Make To Order on the variant,
@@ -27,26 +29,42 @@ class ProductProduct(models.Model):
         compute="_compute_route_ids",
         domain="[('product_selectable', '=', True)]",
         store=False,
+        search="_search_route_ids",
     )
 
     def _compute_is_mto(self):
-        mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False)
         for product in self:
-            if not mto_route:
-                product.is_mto = False
-                continue
-            product.is_mto = mto_route in product.product_tmpl_id.route_ids
+            product.is_mto = product.product_tmpl_id.is_mto
 
     @api.depends("is_mto", "product_tmpl_id.route_ids")
     def _compute_route_ids(self):
-        mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False)
+        mto_routes = self.env["stock.route"].search([("is_mto", "=", True)])
         for product in self:
-            if mto_route and mto_route in product.product_tmpl_id.route_ids:
-                if not product.is_mto:
-                    product.route_ids = product.product_tmpl_id.route_ids - mto_route
-                    continue
-            else:
-                if mto_route and product.is_mto:
-                    product.route_ids = product.product_tmpl_id.route_ids + mto_route
-                    continue
-            product.route_ids = product.product_tmpl_id.route_ids
+            routes = product.product_tmpl_id.route_ids
+            if product.is_mto:
+                routes += mto_routes
+            product.route_ids = routes
+
+    def _search_route_ids(self, operator, value):
+        mto_routes = self.env["stock.route"].search([("is_mto", "=", True)])
+        if operator in ("=", "!=") and value in mto_routes:
+            return [("is_mto", operator, True)]
+        domain = []
+        route_ids = value.copy()
+        for idx, route_id in enumerate(route_ids):
+            if route_id in mto_routes.ids:
+                route_ids.pop(idx)
+                domain = [("is_mto", "=" if operator == "in" else "!=", True)]
+        if route_ids:
+            domain += [("product_tmpl_id.route_ids", operator, route_ids)]
+        return domain
+
+    @api.constrains("is_mto")
+    def _check_template_is_mto(self):
+        for product in self:
+            if not product.is_mto and product.product_tmpl_id.is_mto:
+                raise ValidationError(
+                    self.env._(
+                        "You cannot mark a variant as non MTO when the product is MTO"
+                    )
+                )

product_variant_route_mto/models/product_template.py

@@ -1,4 +1,5 @@
 # Copyright 2023 Camptocamp SA
+# Copyright 2025 Jacques-Etienne Baudoux (BCIM) <[email protected]>
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
 
 from odoo import api, models
@@ -10,30 +11,43 @@ class ProductTemplate(models.Model):
     def write(self, values):
         if "route_ids" not in values:
             return super().write(values)
+
         # As _compute_is_mto cannot use api.depends (or it would reset MTO
         # route on variants as soon as there is a change on the template routes),
         # we need to check which template in self had MTO route activated
         # or deactivated to force the recomputation of is_mto on variants
-        mto_route = self.env.ref("stock.route_warehouse0_mto")
-        template_not_mto_before = self.filtered(lambda t: mto_route not in t.route_ids)
+        templates_mto_before = self.filtered("is_mto")
+        templates_not_mto_before = self - templates_mto_before
+
         res = super().write(values)
-        templates_mto_after = self.filtered(lambda t: mto_route in t.route_ids)
-        templates_mto_added = template_not_mto_before & templates_mto_after
-        templates_mto_removed = (self - template_not_mto_before) & (
-            self - templates_mto_after
-        )
+
+        templates_mto_after = self.filtered("is_mto")
+        templates_not_mto_after = self - templates_mto_after
+
+        templates_mto_added = templates_not_mto_before & templates_mto_after
+        templates_mto_removed = templates_not_mto_after & templates_mto_before
+
         (
             templates_mto_added | templates_mto_removed
         ).product_variant_ids._compute_is_mto()
+
         return res
 
     @api.onchange("route_ids")
     def onchange_route_ids(self):
-        mto_route = self.env.ref("stock.route_warehouse0_mto", raise_if_not_found=False)
-        if (
-            mto_route not in self._origin.route_ids
-            and mto_route in self.route_ids._origin
-        ):
+        mto_routes = self.env["stock.route"].search([("is_mto", "=", True)])
+        if not mto_routes:
+            return
+
+        origin_routes = (
+            self._origin.route_ids if self._origin else self.env["stock.route"]
+        )
+        current_routes = (
+            self.route_ids._origin if self.route_ids else self.env["stock.route"]
+        )
+
+        added_routes = current_routes - origin_routes
+        if set(mto_routes.ids) & set(added_routes.ids):
             # Return warning activating MTO route
             return {
                 "warning": {
@@ -44,10 +58,9 @@ def onchange_route_ids(self):
                     ),
                 }
             }
-        if (
-            mto_route in self._origin.route_ids
-            and mto_route not in self.route_ids._origin
-        ):
+
+        removed_routes = origin_routes - current_routes
+        if set(mto_routes.ids) & set(removed_routes.ids):
             # Return warning deactivating MTO route
             return {
                 "warning": {

product_variant_route_mto/readme/CONTRIBUTORS.md

@@ -1,3 +1,4 @@
 - Matthieu Méquignon \<<[email protected]>\>
 - Akim Juillerat \<<[email protected]>\>
 - Chau Le \<<[email protected]>\>
+- Jacques-Etienne Baudoux (BCIM) \<<[email protected]>\>

product_variant_route_mto/readme/DESCRIPTION.md

@@ -1,2 +1,3 @@
-This module allows to define if a product variant can use the Make To
-Order route without any dependency on its template routes settings.
+This module allows to set a product variant as MTO (enabling the Make To
+Order route on that variant only) while the related product is not MTO.
+However, you cannot mark a variant has non MTO when the template is MTO.

product_variant_route_mto/tests/test_mto_variant.py

@@ -2,6 +2,8 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl)
 import logging
 
+from odoo.exceptions import ValidationError
+
 from .common import TestMTOVariantCommon
 
 onchange_logger = "odoo.tests.form.onchange"
@@ -32,9 +34,8 @@ def test_variants_mto(self):
             self.add_route(pen_template, self.mto_route)
         self.assertVariantsMTO(pens)
         # Disable mto route for black_pen
-        self.toggle_is_mto(black_pen)
-        self.assertVariantsNotMTO(black_pen)
-        self.assertVariantsMTO(blue_pen | green_pen | red_pen)
+        with self.assertRaises(ValidationError):
+            self.toggle_is_mto(black_pen)
         # Disable mto route on the template, reset is_mto on variants
         with self.assertLogs(onchange_logger, level="WARNING"):
             self.remove_route(pen_template, self.mto_route)
@@ -49,20 +50,18 @@ def test_template_routes_updated(self):
         green_pen = self.green_pen
         black_pen = self.black_pen
         self.assertVariantsNotMTO(pens)
-        # If template is set to MTO, all variants are updated
-        with self.assertLogs(onchange_logger, level="WARNING"):
-            self.add_route(pen_template, self.mto_route)
-        self.assertVariantsMTO(pens)
-        # Now toggle a few variants to is_mto == False
-        self.toggle_is_mto(black_pen | blue_pen)
-        self.assertVariantsMTO(green_pen | red_pen)
-        self.assertVariantsNotMTO(black_pen | blue_pen)
+        # Now toggle a variant to is_mto
+        self.toggle_is_mto(black_pen)
+        self.assertVariantsMTO(black_pen)
+        self.assertVariantsNotMTO(green_pen | red_pen | blue_pen)
         # Now modifying template.route_ids to trigger variant's _compute_is_mto
         random_route = self.mto_route.create({"name": "loutourout de la vit"})
         self.add_route(pen_template, random_route)
-        # Template is still MTO, but variants is_mto shouldn't have changed
-        self.assertVariantsMTO(green_pen | red_pen)
-        self.assertVariantsNotMTO(black_pen | blue_pen)
+        self.assertVariantsMTO(black_pen)
+        self.assertVariantsNotMTO(green_pen | red_pen | blue_pen)
+        self.remove_route(pen_template, random_route)
+        self.assertVariantsMTO(black_pen)
+        self.assertVariantsNotMTO(green_pen | red_pen | blue_pen)
 
     def test_template_warnings(self):
         # instanciate variables
@@ -85,19 +84,13 @@ def test_template_warnings(self):
         self.assertIn("Activating MTO route will reset", log_catcher.output[0])
         self.assertVariantsMTO(pens)
 
-        # Disable mto route for black pen
-        self.toggle_is_mto(black_pen)
-        self.assertVariantsNotMTO(black_pen)
-        self.assertVariantsMTO(blue_pen | green_pen | red_pen)
-
         # Enable unrelated route does not raise warning nor reset
         random_route = self.mto_route.create({"name": "loutourout de la vit"})
         with self.assertLogs(onchange_logger) as log_catcher:
             self.add_route(pen_template, random_route)
             _logger.info("No warning raised")
         self.assertNotIn("WARNING", log_catcher.output[0])
-        self.assertVariantsNotMTO(black_pen)
-        self.assertVariantsMTO(blue_pen | green_pen | red_pen)
+        self.assertVariantsMTO(pens)
 
         # Disable mto route on the template,
         # raise warning as is_mto is reset on variants

product_variant_route_mto/views/product_product.xml

@@ -2,17 +2,6 @@
 <!-- Copyright 2023 Camptocamp SA
      License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). -->
 <odoo>
-    <record id="product_normal_form_view" model="ir.ui.view">
-        <field name="name">product.product.form.inherit</field>
-        <field name="model">product.product</field>
-        <field name="inherit_id" ref="product.product_normal_form_view" />
-        <field name="arch" type="xml">
-            <group name="operations" position="inside">
-                <field name="is_mto" />
-            </group>
-        </field>
-    </record>
-
     <record id="product_variant_easy_edit_view" model="ir.ui.view">
         <field name="name">product.product.form.easy.inherit</field>
         <field name="model">product.product</field>