Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage of Raman simulation #282

Open
jktjkt opened this issue Aug 8, 2019 · 3 comments
Open

Test coverage of Raman simulation #282

jktjkt opened this issue Aug 8, 2019 · 3 comments

Comments

@jktjkt
Copy link
Collaborator

jktjkt commented Aug 8, 2019

Hi @aleFerrari , the Raman simulation is currently not covered by automated tests (this is visible in the coverage report saying "codecov/project 65.59% (-13.82%) compared to 71d6a11*).

It would be nice if there is a simple test checking that the simulation engine works well. I think that the scenario should be kept reasonably simple, with just a few signals being checked and with a simplified topology (just one link). I'll be happy to help.

@aleFerrari
Copy link
Contributor

aleFerrari commented Sep 3, 2019

Ok, I will do it. If it is ok will fork from the develop branch.

@cgkelly
Copy link

cgkelly commented May 12, 2021

I have tried the Raman simulation by defining a RamanFiber span, and defining the Raman pump powers and frequencies.
I get the expected Raman gain, but I do not see any gain ripple due to the spacing of the Raman pumps. (I'm not seeing any gain ripple in general, but this is a broader topic even for EDFA only spans that I'm looking into).

@jktjkt
Copy link
Collaborator Author

jktjkt commented May 16, 2021

I have tried the Raman simulation by defining a RamanFiber span, and defining the Raman pump powers and frequencies.
I get the expected Raman gain, but I do not see any gain ripple due to the spacing of the Raman pumps. (I'm not seeing any gain ripple in general, but this is a broader topic even for EDFA only spans that I'm looking into).

@cgkelly , I've created a bugreport for this at #398 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants