Skip to content

Isn't best model saving wrong #98

@harshvardhan2707

Description

@harshvardhan2707
        if abs(np.min(mae) - result[0]) < 0.01:
            checkpoint_best_path = os.path.join(args.checkpoints_dir, 'best_mae.pth')
            torch.save({
                'model': model_without_ddp.state_dict(),
            }, checkpoint_best_path)

Isn't this wrong? Shouldn't the best model be saved like this-

            if(result[0])< np.min(mae):
                checkpoint_best_path = os.path.join(args.checkpoints_dir, 'best_mae.pth')
                torch.save({
                    'model': model_without_ddp.state_dict(),
                }, checkpoint_best_path)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions