rpmlint errors

[TimothyAsirJeyasing]

The following are the rpmlint errors found in 1.5.3 which needs to be fixed:

tendrl-selinux.noarch: E: explicit-lib-dependency libselinux-utils
Is it required to explicitly specify the dependency ?

tendrl-selinux.noarch: W: incoherent-version-in-changelog 1.5.3-1 ['1.5.3-1.el7.centos', '1.5.3-1.centos']
tendrl-selinux.noarch: W: invalid-license LGPLv2.1
tendrl-selinux.noarch: W: dangerous-command-in-%pre cp
tendrl-selinux.noarch: W: dangerous-command-in-%posttrans rm

[mbukatov]

This is a good catch, I have only checked rpmlint results on the specfile while I was putting it together, which looks good:

$ rpmlint tendrl-selinux.spec 
tendrl-selinux.spec: W: invalid-url Source0: tendrl-selinux-1.5.3.tar.gz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

But we have these errors recorded in our CI as well: usmqe_tests.rpm.test_rpm.test_rpmlint[tendrl-selinux]

Looking at the list:

• E: explicit-lib-dependency libselinux-utils I followed SELinux/IndependentPolicy quide, which suggest to include this.
• W: invalid-license LGPLv2.1 - this is the license Rohan asked me to use. But maybe there is a different way it should be written down?
• W: dangerous-command-in-%pre cpand W: dangerous-command-in-%posttrans rm: there is no cp or rm command anywhere in the spec file, this seems to come from rpm macros which SELinux/IndependentPolicy suggests me to use