Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed a bug, resolves submitting empty notes and diary #216

Closed
wants to merge 3 commits into from
Closed

Fixed a bug, resolves submitting empty notes and diary #216

wants to merge 3 commits into from

Conversation

KGLikith
Copy link

@KGLikith KGLikith commented Nov 6, 2024 •
edited
Loading

Description

  • Does not allow empty notes and diaries to be added and throws and error message.
  • Also erases the text as soon as the note or diary is added.

Related Issue

Fixes #198 and #197 (also #177)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Preview

Screen.Recording.2024-11-06.205850.mp4

@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024

@KGLikith is attempting to deploy a commit to the deleksharpgmailcom's projects Team on Vercel.

A member of the Team first needs to authorize it.

@KGLikith
Copy link
Author

KGLikith commented Nov 6, 2024 •
edited
Loading

Is it required to create seperate PR for #197 or is it fine?

@KGLikith KGLikith closed this by deleting the head repository Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Empty Notes and Diary can be submitted
1 participant
@KGLikith