Add GeoJson clustering #7208
Open
Add GeoJson clustering #7208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geojson-clustering
…geojson-clustering
pjonsson
reviewed
Nov 28, 2024
| @@ -602,6 +604,33 @@ function GeoJsonMixin<T extends AbstractConstructor<BaseType>>(Base: T) { | |||
| }); | |||
| } else { | |||
| const dataSource = await this.loadGeoJsonDataSource(geoJsonWgs84); | |||
|
|
|||
| if (this.clustering.enabled) { | |||
| const pinBackgroundColor = this.clustering.pinBackgroundColor; | |||
There was a problem hiding this comment.
I don't know anything about runInAction(...), but a lot of the surrounding code uses that for accessing things in this. Does this code not need that for some reason?
There was a problem hiding this comment.
Hi @pjonsson,
runInAction, like action, is required when you modify an observable.
This code acts before the modification and the modification is already in a runInAction (at line 635).
So, this code not need runInAction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR adds the trait
ClusteringTraitstoGeoJsonTraits. In this way, it becomes possible to enable the clustering of entities made available by Cesium. Clusterized entities are represented as billboards generated by thefromTextfunction ofPinBuilderand report the number of grouped entities. As a result, clustering only works by using Cesium as a viewer, but there are no drawbacks to switching from Cesium to Leaflet at runtime.Test me
Add a GeoJson or WFS layer of points to the catalog and use new parameters
In example:
Checklist
doc/.