Skip to content

Commit ced53ad

Browse files
author
Russ Egan
committed
Some renaming
1 parent 484ffed commit ced53ad

File tree

3 files changed

+13
-8
lines changed

3 files changed

+13
-8
lines changed

v2/handler_test.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -299,7 +299,7 @@ func TestHandlerOptions_ReplaceAttrs(t *testing.T) {
299299

300300
func TestHandlerOptions_Middleware(t *testing.T) {
301301
addAttrMW := func(attr slog.Attr) Middleware {
302-
return HandlerMiddlewareFunc(func(ctx context.Context, record slog.Record, next slog.Handler) error {
302+
return SimpleMiddlewareFn(func(ctx context.Context, record slog.Record, next slog.Handler) error {
303303
record.AddAttrs(attr)
304304
return next.Handle(ctx, record)
305305
})
@@ -332,7 +332,7 @@ func TestHandlerOptions_Clone(t *testing.T) {
332332
},
333333
},
334334
Middleware: []Middleware{
335-
HandlerMiddlewareFunc(func(ctx context.Context, record slog.Record, next slog.Handler) error {
335+
SimpleMiddlewareFn(func(ctx context.Context, record slog.Record, next slog.Handler) error {
336336
return next.Handle(ctx, record)
337337
}),
338338
},
@@ -363,7 +363,7 @@ func TestHandlerOptions_Clone(t *testing.T) {
363363
tC.opts.ReplaceAttrs = append(tC.opts.ReplaceAttrs, func(_ []string, _ slog.Attr) slog.Attr {
364364
return slog.Attr{}
365365
})
366-
tC.opts.Middleware = append(tC.opts.Middleware, HandlerMiddlewareFunc(func(_ context.Context, _ slog.Record, _ slog.Handler) error {
366+
tC.opts.Middleware = append(tC.opts.Middleware, SimpleMiddlewareFn(func(_ context.Context, _ slog.Record, _ slog.Handler) error {
367367
return nil
368368
}))
369369
tC.opts.HandlerFn = nil

v2/middleware.go

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -210,20 +210,25 @@ type Middleware interface {
210210
Apply(slog.Handler) slog.Handler
211211
}
212212

213-
type MiddlewareFunc func(slog.Handler) slog.Handler
213+
// MiddlewareFn adapts a function to the Middleware interface.
214+
type MiddlewareFn func(slog.Handler) slog.Handler
214215

215-
func (f MiddlewareFunc) Apply(h slog.Handler) slog.Handler {
216+
func (f MiddlewareFn) Apply(h slog.Handler) slog.Handler {
216217
return f(h)
217218
}
218219

219-
func (f HandlerMiddlewareFunc) Apply(h slog.Handler) slog.Handler {
220+
// Apply implements Middleware
221+
func (f SimpleMiddlewareFn) Apply(h slog.Handler) slog.Handler {
220222
return &middlewareHandler{
221223
next: h,
222224
middleware: f,
223225
}
224226
}
225227

226-
type HandlerMiddlewareFunc func(ctx context.Context, record slog.Record, next slog.Handler) error
228+
// SimpleMiddlewareFn defines a simple middleware function which intercepts
229+
// *slog.Handler.Handle() calls. SimpleMiddlewareFn adapts this to the Middleware
230+
// interface.
231+
type SimpleMiddlewareFn func(ctx context.Context, record slog.Record, next slog.Handler) error
227232

228233
type middlewareHandler struct {
229234
next slog.Handler

v2/middleware_test.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -365,7 +365,7 @@ func TestHandlerMiddlewareFunc(t *testing.T) {
365365
Level: slog.LevelDebug,
366366
})
367367

368-
middleware := HandlerMiddlewareFunc(func(ctx context.Context, record slog.Record, next slog.Handler) error {
368+
middleware := SimpleMiddlewareFn(func(ctx context.Context, record slog.Record, next slog.Handler) error {
369369
record.AddAttrs(slog.String("foo", "bar"))
370370
return next.Handle(ctx, record)
371371
})

0 commit comments

Comments
 (0)