Skip to content

Add .hip extension. #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Dec 29, 2024
Merged

Conversation

breyerml
Copy link
Contributor

Add the .hip extensions for the HIP language dialect (similar to .cu in CUDA).

@ClausKlein
Copy link
Contributor

Note, there is more to do: #41

@breyerml
Copy link
Contributor Author

Note, there is more to do: #41

I've added the extensions mentioned in this issue.

Question: is there a mechanism to specify the extensions based on the used clang-format version? Or should I add them unconditional like I did?

```
Configuration file(s) do(es) not support Json
```
with clang-formt 18.0.0
Copy link
Owner

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the new extensions! Seems there is still an issue with the CI being outdated. I'll investigate and update the PR.

Comment on lines 82 to 83
'cc', 'cp', 'cpp', 'c++', 'cxx', 'hh', 'hpp', 'hxx', 'inc', 'inl', # C++
'cu', # CUDA
'cc', 'cp', 'cpp', 'c++', 'cxx', 'hh', 'hpp', 'hxx', 'inc', # C++
'ccm', 'cppm', 'cxxm', 'c++m', # C++ Modules
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to remove the inl extension?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: asio use ipp, boost, and ACE use inl

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've re-added the inl file ending and additionally added ipp.

@TheLartians
Copy link
Owner

CI is now fixed, but there's a merge conflict, and I think we should keep the inl extension.

@TheLartians
Copy link
Owner

Thanks for the update! I'm not sure why the CI is not running (and there seems to be no option for me to start it). Can you check if GitHub Actions is enabled on your branch?

@TheLartians
Copy link
Owner

Sorry, I found the issue now and could start the workflow manually! (I was using the "new merge experience" which seems to be missing the button)

Copy link
Owner

@TheLartians TheLartians left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the extension!

@TheLartians TheLartians merged commit 969284a into TheLartians:master Dec 29, 2024
3 checks passed
@breyerml
Copy link
Contributor Author

breyerml commented Jan 8, 2025

For some reason, at one point, the actual ".hip" extension was lost again in this PR :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants