Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working with Remotes: Reword to accurately list the commit message #29195

Open
3 tasks done
hbar1st opened this issue Dec 14, 2024 · 1 comment
Open
3 tasks done

Working with Remotes: Reword to accurately list the commit message #29195

hbar1st opened this issue Dec 14, 2024 · 1 comment
Labels
Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues

Comments

@hbar1st
Copy link

hbar1st commented Dec 14, 2024

Checks

Describe your suggestion

The instructions ask us to:

remove our commit for Create fourth file:
but actually there is no commit called "Create fourth file"
Instead we have "Create third file and create fourth file" as the last commit from the previous exercise

This seems like an oversight that may cause confusion and can easily be fixed by changing this lesson to state "Create third file and create fourth file" instead of "Create fourth file".

The other area related to this that would also need to be corrected is this statement:

We can’t find our fourth file on our local system. Let’s check our GitHub repository to see if it’s there.
Oh no, we just destroyed it!

In fact, after removing the commit we cannot find the 3rd and the 4th files. So it should be corrected to say:
We can't find our third or fourth files on our local system. Let's check our GitHub repository to see if they're there.
Oh no, we just destroyed them!

Path

Node / JS

Lesson Url

https://www.theodinproject.com/lessons/javascript-working-with-remotes

(Optional) Discord Name

No response

(Optional) Additional Comments

No response

Copy link

This issue is stale because it has had no activity for the last 30 days.

@github-actions github-actions bot added the Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Stale This issue/PR has been inactive for over 30 days and will be closed if inactivity continues
Projects
None yet
Development

No branches or pull requests

1 participant