Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Notifications include link to stream #716

Open
cr45hmurphy opened this issue Nov 13, 2022 · 21 comments
Open

[Feature] Notifications include link to stream #716

cr45hmurphy opened this issue Nov 13, 2022 · 21 comments

Comments

@cr45hmurphy
Copy link

Is your feature request related to a problem? Please describe.
Not related to any current issue or problem.

Describe the solution you'd like
It would be really cool if notifications included a link to the stream. I use the Discord webhook, and it would be cool if the other members could easily click on the notification and see what I'm printing.

Describe alternatives you've considered
None that I know of at this moment.

Additional context
None at the moment.

@cr45hmurphy cr45hmurphy changed the title [Feature] Notification include link to stream [Feature] Notifications include link to stream Nov 13, 2022
@kennethjiang
Copy link
Contributor

@cr45hmurphy Obico support many different kinds of notificaitons. Do you mean just Discord, or all notification channels?

@cr45hmurphy
Copy link
Author

@cr45hmurphy Obico support many different kinds of notificaitons. Do you mean just Discord, or all notification channels?

In my case, Discord. But, from what I can tell, none of the other notifications send a stream link.

Regarding Discord, I'm specifically thinking that a stream link be sent out with a "print start" notification.

@kennethjiang
Copy link
Contributor

@cr45hmurphy We have a bug open for discord: #711

Can you test it for other channels to see if you experience the same issue?

@cr45hmurphy
Copy link
Author

@cr45hmurphy We have a bug open for discord: #711

Can you test it for other channels to see if you experience the same issue?

My Discord notifications haven't ever actually sent images. It's always just been a text notification.

@kennethjiang
Copy link
Contributor

This sounds like just #711. Let me know if you still think you are experiencing a different problem. Otherwise I'll close it.

@cr45hmurphy
Copy link
Author

Does the image normally link to the printing stream? If not, then this is a different request.

@cr45hmurphy
Copy link
Author

cr45hmurphy commented Nov 14, 2022

As stated above, this is a feature request. Currently, the notification link sends you to "https://app.obico.io/printers/". However, this is not the same as the actual shareable stream link that you can provide to others. My feature request is that the share link be included in the notification somehow.

@kennethjiang
Copy link
Contributor

I know what you mean now.

Is the reason why you want the share link to be included is so that you can easily grab it to send it to other people?

@cr45hmurphy
Copy link
Author

I know what you mean now.

Is the reason why you want the share link to be included is so that you can easily grab it to send it to other people?

Currently, I utilize the Discord webhook to send a notification to a text channel when a print job starts. With the ability to send notifications to collaborative communication platforms (Discord, Slack, etc.) there is the inherent idea of inviting others to view the stream. Otherwise, the notifications are simply there for the owner of the print, and that seems somewhat unnecessary.

The hope is that when a print starts and an associated notification gets posted on one of those platforms (Discord, in my case), other users would be able to simply click on the notification and be taken to the live feed of the print, so that they can watch along if they want to.

I realize that the owner (ie. Me) can simply share the live stream URL as well. However, that can change if live stream is ever turned off/on. It just seems that adding that capability to the actual notification would make sharing the feed a little bit easier.

@kennethjiang
Copy link
Contributor

Do you mean Obico should create a shared link if one doesn't exist yet? I'm afraid this will surprise many users.

@kennethjiang
Copy link
Contributor

An alternative design is to include the shared link only if it has been manually created by the account owner. In this case, it may still come as an unexpected surprise. This shared link is supposed to be confidential and only shared manually by the account owner.

@cr45hmurphy
Copy link
Author

An alternative design is to include the shared link only if it has been manually created by the account owner. In this case, it may still come as an unexpected surprise. This shared link is supposed to be confidential and only shared manually by the account owner.

What about a way for the owner to select an option to allow for the sharing of the feed link? Like, a way that the user could turn off the sharing of the feed URL if they wanted to.

@kennethjiang
Copy link
Contributor

Good point. This option can be a checkbox in the sharing dialog. Good call.

@cr45hmurphy
Copy link
Author

Is there a way to have this moved to the Octopi repo instead? I just realized I put it in the wrong repo.

@kennethjiang
Copy link
Contributor

I'm confused. This seems like a feature request for Obico. Why do you want it to be in Octopi? In any case, if you want it in the octopi repo, please contact the octopi repo owner.

@cr45hmurphy
Copy link
Author

Sorry, I meant the Obico Octopi repo. I didn't mean to have this placed in the Obico Server repo.

@cr45hmurphy
Copy link
Author

Obico Octoprint, rather (https://github.com/TheSpaghettiDetective/OctoPrint-Obico)

@kennethjiang
Copy link
Contributor

This is a server-side feature. So this is the right repo for it.

@cr45hmurphy
Copy link
Author

Okay. I thought this repo was specifically for setting up your own Obico server? Does it also affect features on the cloud-hosted option as well?

@kennethjiang
Copy link
Contributor

Obico cloud and self-hosted Obico servers are essentially the same code.

@cr45hmurphy
Copy link
Author

Oh okay! Wanted to ensure I wasn't putting this in the wrong repo. Thank you for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants