Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI misalignments #32

Open
HarryMichal opened this issue Feb 3, 2019 · 1 comment
Open

UI misalignments #32

HarryMichal opened this issue Feb 3, 2019 · 1 comment

Comments

@HarryMichal
Copy link

HarryMichal commented Feb 3, 2019

Hi, I just started exploring the codebase and one of the easiest (and most likely less important) tasks to seems to fix various misalignments of the UI. It is very visible in the lobby screen.

I highlighted some problems in a screenshot:
disastles-uiproblems

  1. The title of the box
  2. Name of a player is too close to the ready/not ready/loading button; it would be better if the button was aligned to the right
  3. it's not centered
  4. the box sizes of the labels and the actions are equal; labels don't need really big boxes
  5. almost the same as 4.
  6. the buttons are overlapping
  7. it's not centered; this one is not really important

These things can be mostly fixed with some CSS or Grid adjustments.

EDIT: I took the screenshot on a 4:3 screen with resolution 1280:1024 but it behaves the same on a 16:9 screen with resolution 1366:768. And the browser was Chrome.

@HarryMichal
Copy link
Author

I tried to fix some of the problems I listed.

disastles-uifixes1

  1. I made padding a bit bigger by few pixels. Looks fine.
  2. Fixed by adjusting button width to 'auto'
  3. Adjusted Grid
  4. and 5. Again Grid + changes to input component
  5. Grid
  6. Can be aligned but doesn't look too better.

Also I used at few occasions alignItems prop in Grid. It aligns items vertically. There is other prop called justify but it has to be used in a container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant