Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove warning blocks from CMake and fix the underlying issues #44

Open
jkulawik opened this issue Jun 15, 2024 · 2 comments
Open

Remove warning blocks from CMake and fix the underlying issues #44

jkulawik opened this issue Jun 15, 2024 · 2 comments
Milestone
Build clean up

Comments

@jkulawik
Copy link
Collaborator

I.e. the stuff inside add_compile_options which starts with -W.
@jkulawik
Copy link
Collaborator Author

Also: pragma warning silencers, e.g. #pragma warning( disable : 4786 )

@jkulawik jkulawik added this to the Build clean up milestone Jun 16, 2024
jkulawik pushed a commit that referenced this issue Jul 6, 2024
#44 separate flushed controller input counters to get rid of a warning
3165061
jkulawik pushed a commit that referenced this issue Jul 6, 2024
#44: fix void* deletion and un-silence warning; add more specific not…
f857f54 
…es about other warnings
@jkulawik
Copy link
Collaborator Author

jkulawik commented Jul 6, 2024

It seems like the ones silenced with #pragma warning are specific to MSVC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Build clean up
Development

No branches or pull requests
1 participant
@jkulawik