Skip to content

Commit cde9c93

Browse files
authored
Select widget handle default parameter refresh (#9617)
* select widget handle default parameter refresh * Add change note
1 parent d07fe25 commit cde9c93

File tree

2 files changed

+19
-7
lines changed

2 files changed

+19
-7
lines changed

core/modules/widgets/select.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@ SelectWidget.prototype.handleChangeEvent = function(event) {
8282
if(this.selectMultiple == false) {
8383
var value = this.getSelectDomNode().value;
8484
} else {
85-
var value = this.getSelectValues()
86-
value = $tw.utils.stringifyList(value);
85+
var value = this.getSelectValues();
86+
value = $tw.utils.stringifyList(value);
8787
}
8888
this.wiki.setText(this.selectTitle,this.selectField,this.selectIndex,value);
8989
// Trigger actions
@@ -118,7 +118,7 @@ SelectWidget.prototype.setSelectValue = function() {
118118
}
119119
}
120120
// Assign it to the select element if it's different than the current value
121-
if (this.selectMultiple) {
121+
if(this.selectMultiple) {
122122
value = value === undefined ? "" : value;
123123
var select = this.getSelectDomNode();
124124
var child,
@@ -156,14 +156,14 @@ SelectWidget.prototype.getSelectValues = function() {
156156
select = this.getSelectDomNode();
157157
result = [];
158158
options = select && select.options;
159-
for (var i=0; i<options.length; i++) {
159+
for(var i=0; i<options.length; i++) {
160160
opt = options[i];
161-
if (opt.selected) {
161+
if(opt.selected) {
162162
result.push(opt.value || opt.text);
163163
}
164164
}
165165
return result;
166-
}
166+
};
167167

168168
/*
169169
Compute the internal state of the widget
@@ -192,7 +192,7 @@ Selectively refreshes the widget if needed. Returns true if the widget or any of
192192
SelectWidget.prototype.refresh = function(changedTiddlers) {
193193
var changedAttributes = this.computeAttributes();
194194
// If we're using a different tiddler/field/index then completely refresh ourselves
195-
if(changedAttributes.tiddler || changedAttributes.field || changedAttributes.index || changedAttributes.tooltip || changedAttributes.tabindex || changedAttributes.disabled) {
195+
if(changedAttributes.tiddler || changedAttributes.field || changedAttributes.index || changedAttributes.tooltip || changedAttributes.default || changedAttributes.tabindex || changedAttributes.disabled) {
196196
this.refreshSelf();
197197
return true;
198198
} else {
Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,12 @@
1+
change-category: usability
2+
change-type: bugfix
3+
created: 20260125195754439
4+
description: Refresh widget if "default" parameter input value is changed
5+
github-contributors: pmario
6+
github-links: https://github.com/TiddlyWiki/TiddlyWiki5/pull/9217
7+
modified: 20260125195754439
8+
release: 5.4.0
9+
tags: $:/tags/ChangeNote
10+
title: $:/changenotes/5.4.0/#9217
11+
type: text/vnd.tiddlywiki
12+

0 commit comments

Comments
 (0)