Should $tw.utils.repackPlugin() update modified?

[andrewgoz]

Since I've been repacking a lot of my plugins lately, I've noticed that $tw.utils.repackPlugin() does not update the modified field. Is there a reason why not?

I've modified the following line in my TW:

TiddlyWiki5/core/modules/utils/pluginmaker.js

Line 63 in e753851

$tw.wiki.addTiddler(new $tw.Tiddler(pluginTiddler,{text: JSON.stringify({tiddlers: plugins},null,4), version: version}));

by adding , modified: $tw.utils.stringifyDate(new Date()) after the version. I'm not seeing any problems?

[pmario]

As far as I know, repackPlugin() is not exposed to users. How do you call it?

[pmario]

It may be worth to add an options object to the function call and make it configurable.

exports.repackPlugin = function(title,additionalTiddlers,excludeTiddlers,options) {

[andrewgoz]

As far as I know, repackPlugin() is not exposed to users. How do you call it?

In the console, as per: https://tiddlywiki.com/dev/#How%20to%20create%20plugins%20in%20the%20browser

However, I've recently started using the Tinka plugin, which provides an easy-to-use button!

While I'm sure a generic options might be useful, I think that since repackPlugin() is modifying the tiddler, that it should be updating the modified field regardless.

[pmario]

I think, by default it should update the modified field and it should respect the $:/config/TimestampDisable tiddler, which allows us to change that behaviour