Use automated tooling to enforce coding style

[Jermolene]

There is an opportunity to use JSCS to automatically enforce our chosen coding style guidelines, as described in this blog post.

• Build a .jscsrc file that corresponds to our existing coding standards
• Add it to the dev dependencies of the repo
• Add a script for checking conformance, and call it from bld/test.sh

Any help with this ticket would be much appreciated.

[pmario]

+1
I did install the JSCS plugin for the Brackets editor some time ago. There it works similar to the JSHint plugin. Every time you save you get some warnings that you can fix, or ignore :/

There are several plugins for different popular editors.

I also had a look at some predefined coding guidelines, but non of them fits to your actual settings. I didn't know about the auto-configure option. ... Would be worth a try.

• We will need some special settings for our leading comments and comments in general.
• Most of the presets prefer spaces instead of tabs, but this can be overwritten.

And if JSCS implementation is on the way, it would be nice to run all source files through JSHint too. There are a lot of warnings all over the places atm. Especially "semicolons" and "var" keyword usage, are a problem. ... But since programs could change behaviour if we don't take care fixing them, I didn't touch them.

[sukima]

Our company enforces coding standards with Hound-ci but that uses JSHint.

[Jermolene]

@sukima and @pmario I'm embarrassed by how bad the TW5 JSHint feedback report has got. I did once keep on top of it. I'll open a ticket about it.

[pmario]

I think JSCS looks promising, if we find the right parameters, that fit the existing style.

[pmario]

related to: Remove function wrapper / add matching dprint and eslint configurations #7596