Skip to content

[BUG] search:*:words doesn't find binary tiddlers e.g. application/pdf #9246

@BurningTreeC

Description

@BurningTreeC

Describe the bug

https://talk.tiddlywiki.org/t/does-search-words-have-an-issue-or-do-i-misunderstand/13282/7

We've found an issue with the search operator in combination with the * wildcard for "all fields"
If the tiddler is of type application/pdf and has the search term in its title it will not be found by the filter expression


@ericshulman posted a nice example in the thread linked above that can be used to inspect:

fields:<br>
<$select tiddler="$:/config/fields" multiple>
   <option value="*">* = all fields</option>
   <$list filter="[fields[]sort[]]"><option><<currentTiddler>></option></$list>
</$select><br>
flags:<br>
<$select tiddler="$:/config/flags" multiple>
   <$list filter="literal whitespace regexp words some casesensitive anchored">
      <option><<currentTiddler>></option>
   </$list>
</$select><br>
search:<br>
<$edit-text tag=input tiddler="$:/temp/search/input"/>

<$let fields={{$:/config/fields}} flags={{$:/config/flags}}>
Filter = <$text text=`[search:$(fields)$:$(flags)${$:/temp/search/input}]`/>
<p/>
<$list filter=`[search:$(fields)$:$(flags)${$:/temp/search/input}]`><$link/><br></$list>
</$let>

Expected behavior

I expect that all binary tiddlers are included in the list

To Reproduce

  • go to https://tiddlywiki.com
  • paste the above example in a new tiddler
  • create a new tiddler with "Zorro" in its title
  • set "fields" to * in the search tiddler
  • set "flags" to words in the search tiddler
  • use the search input field in the search tiddler and write "Zorro"
  • see that the tiddler with "Zorro" in its title is in the list
  • change the type of the "Zorro" tiddler to application/pdf
  • notice that it has disappeared from the search results

Screenshots

No response

TiddlyWiki Configuration

  • TiddlyWiki v5.3.8

Additional context

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugConfirmed, replicable bug

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions