Fix fragment commit delete ordering (#5774)

This change reverse the delete order of fragments and their associated
commits to delete the commits first.

This prevents errors that occurred previously if a commit was still
present but the fragment had been removed or partially removed.

Closes #5773

---
TYPE: BUG
DESC: Delete commits before fragments

Author: cl-earthscope

tiledb/sm/array/array.cc

@@ -670,10 +670,12 @@ void Array::delete_fragments(
   auto& vfs = resources.vfs();
   throw_if_not_ok(parallel_for(
       &resources.compute_tp(), 0, fragment_uris.size(), [&](size_t i) {
-        vfs.remove_dir(fragment_uris[i].uri_);
+        // Delete the commit first
         if (vfs.is_file(commit_uris_to_delete[i])) {
           vfs.remove_file(commit_uris_to_delete[i]);
         }
+        // Delete the fragment next
+        vfs.remove_dir(fragment_uris[i].uri_);
         return Status::Ok();
       }));
 }

tiledb/sm/array/array_directory.cc

@@ -323,10 +323,12 @@ void ArrayDirectory::delete_fragments_list(
   throw_if_not_ok(parallel_for(
       &resources_.get().compute_tp(), 0, uris.size(), [&](size_t i) {
         auto& vfs = resources_.get().vfs();
-        vfs.remove_dir(uris[i]);
+        // Delete the commit first
         if (vfs.is_file(commit_uris_to_delete[i])) {
           vfs.remove_file(commit_uris_to_delete[i]);
         }
+        // Delete the fragment next
+        vfs.remove_dir(uris[i]);
         return Status::Ok();
       }));
 }

tiledb/sm/misc/constants.cc

@@ -96,9 +96,9 @@ const std::string array_enumerations_dir_name = "__enumerations";
 const std::vector<std::string> array_dir_names = {
     array_schema_dir_name,
     array_metadata_dir_name,
+    array_commits_dir_name,
     array_fragment_meta_dir_name,
     array_fragments_dir_name,
-    array_commits_dir_name,
     array_dimension_labels_dir_name,
     array_enumerations_dir_name};