Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LOSS: Doesn't account for global installs. #43

Open
the-golem opened this issue Nov 20, 2011 · 1 comment
Open

LOSS: Doesn't account for global installs. #43

the-golem opened this issue Nov 20, 2011 · 1 comment

Comments

@the-golem
Copy link
Contributor

I realized this weekend that LOSS doesn't account for global installs, in that it only changes the HKCU settings in the registry. This meant that a "global" installation wouldn't even be able to change the shell using LOSS. The following is an IRC conversation with Tobbe discussing solutions.

Tobbe:
    So, think of it like this 
    "Jane: Who the hell put LS on here? Let's switch back to explorer" 
    "Joe: WTF? didn't I just install LS, let's switch back to LS" etc... 
    That's why the switching is on a per user basis, even if you installed for all users

the-golem
    :-/
    then don't give them the choice in the first place

Tobbe 
    the choice to do what?
    switch shell?

the-golem
    the choice to do it for all users

Tobbe
    that's the way it is. There is no choice to switch shell for all users
    (in LOSS)

the-golem
    no, i mean the choice to install it

Tobbe
    I don't want to limit the posibilities

the-golem 
    ummm ,k so how i understand it, is that when installing, your script says:
    if the user chose to install it on a per user basis, change the IniFileMap to "USR:" 
    otherwise, leave it as "SYS:" SYS points to the localmachine winlogon, usr points 
    to the hkcu winlogon. Now, if the user wants to switch his shell,
    it only changes the hkcu setting.

Tobbe  
    I see where you're going

the-golem  
    since the iniFileMapping points to SYS, changing hkcu has no impact

Tobbe  
    yeah :(. you're right. There is a bug here :(

the-golem
    so, lets revisit our options.
        1) Don't give them the option. Install for current user
        2) Give options, include machine-wide support in LOSS
        3) Keep as is, however, if it's installed per machine, then change the inifilemap 
             so that it changes on a userbasis
        The way I figured it, if someone installed it machine wide, either he's the only user,
        or everyone else is fine with it

Tobbe
    How about this? Always change it to USR: and always make sure the current user
    gets LS as shell. If it's a "global" install, give all users shortcuts on their desktops/start 
    menus to switch to LS, if it's a "local" install, only give the current user those shortcuts.
    Does that sound like a good idea to you?

the-golem
    by "always change it to USR" you mean in LOSS, and the rest for the installer?

Tobbe
    no, always change to USR, even in the installer

the-golem
    ah ok. that's probably the better option, but  we have to change how
    global installations are done then

Tobbe
    yes
@the-golem the-golem mentioned this issue Nov 24, 2011
@Tobbe
Copy link
Owner

Tobbe commented Nov 27, 2011

Apparently I deliberately made the "install for all users" work the way it does now... See closed issue #18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants