Feat: Add environments command to list environments #3770
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
izeigerman
reviewed
Feb 2, 2025
izeigerman
reviewed
Feb 2, 2025
izeigerman
reviewed
Feb 2, 2025
|
Thanks a lot for your contribution! Left some comments |
lafirm
force-pushed
the
list_environments
branch
10 times, most recently
from
76e3f18 to
eda4fa7
Compare
lafirm
force-pushed
the
list_environments
branch
from
639bdd6 to
91d134b
Compare
|
@izeigerman, have reworked the PR based on your comments, really appreciate if you re-review. Thanks :) |
lafirm
force-pushed
the
list_environments
branch
from
95c3ac7 to
18e1e8c
Compare
izeigerman
reviewed
Feb 14, 2025
izeigerman
reviewed
Feb 14, 2025
lafirm
force-pushed
the
list_environments
branch
from
2a553da to
8217e07
Compare
lafirm
force-pushed
the
list_environments
branch
from
8217e07 to
0f24f75
Compare
izeigerman
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
@lafirm this looks great! Let's rebase and resolve conflicts and then I'll merge this. Thanks a lot for addressing comments!
lafirm
force-pushed
the
list_environments
branch
from
3e51ac2 to
c5079ef
Compare
done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3732
I came across this feature request and found it interesting. I made some assumptions and created this PR. Please review and share your feedback. thanks :)