Feat: Add environments command to list environments #3770
Conversation
sqlmesh/cli/main.py
Outdated
| @cli_analytics | ||
| def environments(obj: Context, expiry_ds: bool) -> None: | ||
| """Prints the list of SQLMesh environments with its expiration datetime.""" | ||
| environments = {e.name: e.expiration_ts for e in obj.state_sync.get_environments()} |
There was a problem hiding this comment.
Just a heads up that environment objects are pretty large and loading and parsing them all at once can be a pretty long and memory-intensive operation for big projects with a lot of environments.
A better approach could be having a specialized method in the the state_sync.py that only fetches limited fields like names.
There was a problem hiding this comment.
sure, I'll do this. Thanks :)
sqlmesh/cli/main.py
Outdated
| environment_names = list(environments.keys()) | ||
| if expiry_ds: | ||
| max_width = len(max(environment_names, key=len)) | ||
| print( |
There was a problem hiding this comment.
I think we should be using the console instance here as well.
| ) | ||
| @line_magic | ||
| @pass_sqlmesh_context | ||
| def environments(self, context: Context, line: str) -> None: |
There was a problem hiding this comment.
This looks like the exact copy-paste of the code above. It might be worse considering having a method as part of Context that prints this.
|
Thanks a lot for your contribution! Left some comments |
lafirm
force-pushed
the
list_environments
branch
10 times, most recently
from
76e3f18 to
eda4fa7
Compare
lafirm
force-pushed
the
list_environments
branch
from
639bdd6 to
91d134b
Compare
|
@izeigerman, have reworked the PR based on your comments, really appreciate if you re-review. Thanks :) |
Fixes #3732
I came across this feature request and found it interesting. I made some assumptions and created this PR. Please review and share your feedback. thanks :)