Skip to content

Changing start to older date can lead to out-of-order execution & miss intervals #4837

Open
@georgesittas

Description

@georgesittas

Assume we have the following SQLMesh project (using a DuckDB connection):

  • models/a.sql
MODEL (name s.a, kind INCREMENTAL_BY_TIME_RANGE (time_column ds), start '2023-01-02');
SELECT ds FROM VALUES ('2023-01-01'), ('2023-01-02'), ('2023-01-03') AS t(ds)
  • models/b.sql
MODEL (name s.b, kind INCREMENTAL_BY_TIME_RANGE (time_column ds), start '2020-01-01');
SELECT ds FROM s.a
  • models/c.sql
MODEL (name s.c, kind INCREMENTAL_BY_TIME_RANGE (time_column ds), start '2023-01-02');
SELECT ds FROM s.b
  1. Run sqlmesh plan --no-prompts --auto-apply
  2. Change start to '2023-01-01' for s.a and s.c
  3. Run sqlmesh plan --no-prompts --auto-apply

A couple of things are off:

  • The modified models are disconnected in the evaluation dag: {('"db"."s"."a"', ((1672531200000, 1672617600000), 0)): set(), ('"db"."s"."c"', ((1672531200000, 1672617600000), 0)): set()}. This can lead to out-of-order execution, even though s.c depends on s.a indirectly.
  • After applying the 2nd plan, I don't see the date 2023-01-01 in either s.b or s.c– only s.a has it. This is a side-effect of the previous bullet, because sqlmesh sees that we've already computed the interval 2023-01-01 for s.b, since it starts earlier than that, so it doesn't recompute it. Hence, s.c, who sources from s.b, ends up with stale data.

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions