Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why is rounding the default? #94

Open
WorldMaker opened this issue Jun 19, 2019 · 1 comment
Open

Why is rounding the default? #94

WorldMaker opened this issue Jun 19, 2019 · 1 comment

Comments

@WorldMaker
Copy link

Shouldn't rounding be more in the realm of the user and their particular use case (display method, graph system, etc) rather than the default?

While you can change the precision, there's still going to be some precision loss by the nature of the rounding formula used here if you end up in overflow or underflow scenarios. It would seem to me better to provide the "raw" values by default and rounding as opt-in.

@ecc521
Copy link

ecc521 commented Aug 9, 2021

Completely agree on this one - worse yet, the rounding does not adjust for decimal values, and is done during calculations, not after the fact, resulting in wildly incorrect r2 values, and bad results.

There NEEDS to be a way to opt-out of rounding - and while changing the default would be semi-breaking (could cause existing projects to overflow UIs), the current design is problematic enough that it is really worth considering (moving rounding to after the fact only would also help)

Example of incorrect r2:
Screen Shot 2021-08-08 at 8 06 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants