fix(link): make anchor attrs optional

Author: Erbil Nas

src/components/link/bl-link.test.ts

@@ -15,11 +15,12 @@ describe("bl-link", () => {
     expect(el.kind).to.equal("primary");
     expect(el.href).to.equal("javascript:void(0)");
     expect(el.target).to.equal("_self");
-    expect(el.rel).to.equal("");
-    expect(el.hreflang).to.equal("");
-    expect(el.type).to.equal("");
-    expect(el.download).to.equal("");
-    expect(el.ping).to.equal("");
+    expect(el.rel).to.be.undefined;
+    expect(el.hreflang).to.be.undefined;
+    expect(el.type).to.be.undefined;
+    expect(el.referrerPolicy).to.be.undefined;
+    expect(el.download).to.be.undefined;
+    expect(el.ping).to.be.undefined;
     expect(el.ariaLabel).to.equal("");
   });
 
@@ -167,4 +168,17 @@ describe("bl-link", () => {
       expect(link?.getAttribute("target")).to.equal(target);
     }
   });
+
+  it("renders custom icon slot", async () => {
+    const el = await fixture<BlLink>(html`
+      <bl-link href="/">
+        Link Text
+        <bl-icon name="settings" slot="icon"></bl-icon>
+      </bl-link>
+    `);
+
+    const slot = el.shadowRoot!.querySelector('slot[name="icon"]');
+
+    expect(slot).to.exist;
+  });
 });

src/components/link/bl-link.ts

@@ -67,37 +67,37 @@ export default class BlLink extends LitElement {
    * Example: "noopener noreferrer"
    */
   @property({ type: String, reflect: true })
-  rel: HTMLAnchorElement["rel"] = "";
+  rel?: HTMLAnchorElement["rel"];
 
   /**
    * Language of the linked document
    */
   @property({ type: String, reflect: true })
-  hreflang: HTMLAnchorElement["hreflang"] = "";
+  hreflang?: HTMLAnchorElement["hreflang"];
 
   /**
    * MIME type of the linked document
    */
   @property({ type: String, reflect: true })
-  type: HTMLAnchorElement["type"] = "";
+  type?: HTMLAnchorElement["type"];
 
   /**
    * Referrer policy for the link
    */
   @property({ type: String, reflect: true, attribute: "referrerpolicy" })
-  referrerPolicy: HTMLAnchorElement["referrerPolicy"] = "";
+  referrerPolicy?: HTMLAnchorElement["referrerPolicy"];
 
   /**
    * Whether to download the resource instead of navigating to it
    */
   @property({ type: String, reflect: true })
-  download: HTMLAnchorElement["download"] = "";
+  download?: HTMLAnchorElement["download"];
 
   /**
    * Ping URLs to be notified when following the link
    */
   @property({ type: String, reflect: true })
-  ping: HTMLAnchorElement["ping"] = "";
+  ping?: HTMLAnchorElement["ping"];
 
   private get isStandalone(): boolean {
     return this.variant === "standalone";