Jump buffering in orbinaut

[ShineStar91]

im having difficulty adding a jump buffer to this engine anyone know where to start.

[TrianglyRU]

Jumping is handled by scr_player_jump_start(). When the player is airborne, this script is not called, which means the player cannot jump. The best solution would be to also call scr_player_jump_start() while the player is airborne and include a time check within the script to determine whether the player should be allowed to jump

[ShineStar91]

I forgot to tell you I was able to implement the rest myself, but there's a flaw where it lets you infinitely jump. Do you have any idea why this happens?

[TrianglyRU]

How would I know, I don't know your implementation of it

[ShineStar91]

/// @function scr_player_jump_start
function scr_player_jump_start()
{
gml_pragma("forceinline");

if forced_roll || action == ACTION_SPINDASH || action == ACTION_DASH
{
	exit;
}

if !input_press.action1 && buffer_counter <= 0 
{
	exit;
}
buffer_counter = buffer_max;

// Determine ceiling distance based on tile behaviour ("collision mode")
var MAX_CEILING_DIST = 6;

var _x, _y;
var _ceil_dist = MAX_CEILING_DIST;

switch tile_behaviour
{
	case TILEBEHAVIOUR.DEFAULT:
		_y = y - radius_y;
		_ceil_dist = tile_find_2v(x - radius_x, _y, x + radius_x, _y, DIRECTION.NEGATIVE, tile_layer, tile_behaviour)[0];		
	break;

	case TILEBEHAVIOUR.ROTATE_90:
		_x = x - radius_y;
		_ceil_dist = tile_find_2h(_x, y - radius_x, _x, y + radius_x, DIRECTION.NEGATIVE, tile_layer, tile_behaviour)[0];
	break;

	case TILEBEHAVIOUR.ROTATE_270:
		_x = x + radius_y;
		_ceil_dist = tile_find_2h(_x, y - radius_x, _x, y + radius_x, DIRECTION.POSITIVE, tile_layer, tile_behaviour)[0];
	break;
}

if _ceil_dist < MAX_CEILING_DIST
{
	exit;
}

// They made four games excluding CD, how did they not fix it :cry:
if !global.fix_jump_size && global.player_physics != PHYSICS_CD
{
	radius_x = radius_x_normal;
	radius_y = radius_y_normal;
}

if animation != ANI_SPIN
{	
	y += radius_y - radius_y_spin;
	radius_x = radius_x_spin;
	radius_y = radius_y_spin;
}
else if !global.no_roll_lock && global.player_physics != PHYSICS_CD
{
	air_lock_flag = true;
}
var final_jump_height = grv + abs(jump_vel);
if buffer_counter > 0
{
	buffer_counter --;
}

// Apply velocity changes and update state
vel_x -= final_jump_height * dsin(angle);
vel_y -= final_jump_height * dcos(angle);
is_jumping = true;
coyote_time = 0;
buffer_counter = 0;
buffered_jump_usable = true;
is_grounded = false;
on_object = noone;
set_push_anim_by = noone;
stick_to_convex = false;
animation = ANI_BOUNCE;
audio_play_sfx(sfx_jump);

// Exit the player control routine
return true;

}

[ShineStar91]

wait nevermind i fixed it my implementation was missing a few things

[TrianglyRU]

Yeah I was about to slight edit your code. Glad you've figured it out tho!