In version 0.99.3, images are not displayed when printing notes.

[mnmmo]

In version 0.99.3, images are not displayed when printing notes.

[dosubot[bot]]

This is likely caused by the switch from jsdom to node-html-parser in version 0.99.3, which changed how HTML content—including images—is parsed for printing. node-html-parser doesn't support the full DOM API, so image elements may not be handled correctly in the print output, resulting in them being omitted. The main place to focus for a fix is the printNote.ts file, where note content is prepared for printing. There isn't a documented workaround or fix yet, but the parser change is the most probable cause of the regression.
Details on the parser change

To reply, just mention @dosu.

---

^{How did I do? Good | Irrelevant | Incorrect | Verbose | Hallucination | Report 🐛 | Other}    

[eliandoran]

@mnmmo , can you provide a sample note?

[mnmmo]

@mnmmo , can you provide a sample note?

I am using Windows 11 with Edge, and the service version is deployed via Docker.

Notes show

Printed result

sample.zip
sample - Trilium Notes.pdf

[eliandoran]

@mnmmo , I can't reproduce for this specific note, but I was able to reproduce on documents with lots of images where only half of them loaded.

Please check tomorrow's nightly build and tell me if it's OK.
Should be fixed by f20078f.

[mnmmo]

@mnmmo , I can't reproduce for this specific note, but I was able to reproduce on documents with lots of images where only half of them loaded.

Please check tomorrow's nightly build and tell me if it's OK. Should be fixed by f20078f.

@eliandoran Thank you for your work. This issue has been fixed in version 0.99.4.