Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release notes languages management #1104

Open
ChumachenkoRoman opened this issue Oct 19, 2023 · 6 comments
Open

Release notes languages management #1104

ChumachenkoRoman opened this issue Oct 19, 2023 · 6 comments
Labels
dontclose Prevents the stale bot from closing this issue/pr enhancement Indicates new feature requests feature:listing Involves resource generation and app metadata

Comments

@ChumachenkoRoman
Copy link

Our app currently is published in different regions but uses only English release notes. Is there any way to publish single release notes file for all languages?

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent
activity. It will be closed if no further activity occurs. Thank you for your
contributions.

@github-actions github-actions bot added the waiting-for-reply Indicates that an issue or pull request needs more information label Oct 27, 2023
@github-actions github-actions bot closed this as completed Nov 3, 2023
@SUPERCILEX SUPERCILEX added enhancement Indicates new feature requests feature:listing Involves resource generation and app metadata dontclose Prevents the stale bot from closing this issue/pr and removed waiting-for-reply Indicates that an issue or pull request needs more information labels Nov 3, 2023
@SUPERCILEX SUPERCILEX reopened this Nov 3, 2023
@SUPERCILEX
Copy link
Collaborator

You'd have to implement this, but yeah probably.

@ChumachenkoRoman
Copy link
Author

We used straightforward approach: we created default files for all available languages and created simple bash script which writes same release notes to each one. So we update all those files before assembling release build and that's it.

I was curious if there is another way to achieve same result?

@SUPERCILEX
Copy link
Collaborator

Yeah, no better way unfortunately. This is a very reasonable request though so I'd accept a PR that supports a default language folder. The one thing that concerns me is how we upload all those languages to the Play API: do we need to hardcode a list of language codes? Ideally the Play API would support a default.

@ChumachenkoRoman
Copy link
Author

Maybe I'm getting you wrong here but the default file should be located under a language-named directory for it to be handled to play correctly

@SUPERCILEX
Copy link
Collaborator

Yeah that's correct. I'm saying that if someone wants to open a PR to change that, I'm onboard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dontclose Prevents the stale bot from closing this issue/pr enhancement Indicates new feature requests feature:listing Involves resource generation and app metadata
Projects
None yet
Development

No branches or pull requests

2 participants