You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There are times when symbols change over time. For instance:
/*
* V8_SCOPEINFO_IDX_FIRST_VARS' value was 4 in V8 3.7 and up,
* then 5 when StrongModeFreeVariableCount was added with
* https://codereview.chromium.org/1005063002, and 6 when
* ContextGlobalCount was added with
* https://codereview.chromium.org/1218783005.
* Since the current V8_CONSTANT_FALLBACK macro doesn't allow
* us to specify different values for different V8 versions,
* these are hardcoded below.
*/
Rather than having one case defined in v8_constants or v8_objects and others defined in a series of if statements, it should be possible to mark each v8_constant_t or v8_offset_t with an "add" version and a "remove" version (rather than just one of them). With this, it would be possible to cleanly handle changes using multiple v8_constant_t or v8_object_t elements for the same symbol and non-overlapping versions.
The text was updated successfully, but these errors were encountered:
mgerdts
changed the title
need more flexible way to configure symbols that are added then removed or changed
better handling for add then removed or changed symbols
May 31, 2019
There are times when symbols change over time. For instance:
Rather than having one case defined in
v8_constants
orv8_objects
and others defined in a series of if statements, it should be possible to mark eachv8_constant_t
orv8_offset_t
with an "add" version and a "remove" version (rather than just one of them). With this, it would be possible to cleanly handle changes using multiplev8_constant_t
orv8_object_t
elements for the same symbol and non-overlapping versions.The text was updated successfully, but these errors were encountered: