plugins tests not updated to use tape

[marsell]

The tests in tests/plugins still refer to @smaller/tap, but cloudapi now uses tape. Running the tests in tests/plugins fails.

Sadly, no longer have logs for this to post here.

[marsell]

Before:

[root@e5ad067e-ae5e-4505-933b-a31190be1489 (lab:cloudapi0) /opt/smartdc/cloudapi/test]# ./runtests -f plugins
/opt/smartdc/cloudapi
# Setup a clean output dir (/var/tmp/cloudapitest).
# Running filtered set of test files: test/plugins/filter-owner-networks.test.js
test/plugins/free-tier.test.js
test/plugins/machine-email.test.js
test/plugins/plugin-manager.test.js
test/plugins/provision-limits.test.js
Uncaught Error: Cannot find module '@smaller/tap'

FROM
Function.Module._resolveFilename (module.js:478:5)
Function.Module._load (module.js:424:25)
Module.require (module.js:504:17)
require (internal/module.js:20:19)
Object.<anonymous> (/opt/smartdc/cloudapi/test/plugins/filter-owner-networks.test.js:11:35)
Module._compile (module.js:577:32)
Object.Module._extensions..js (module.js:586:10)
Module.load (module.js:494:32)
tryModuleLoad (module.js:453:12)
Function.Module._load (module.js:445:3)
Module.runMain (module.js:611:10)
run (bootstrap_node.js:394:7)
startup (bootstrap_node.js:160:9)
bootstrap_node.js:507:3
./runtests: line 115: 59669 Illegal Instruction     (core dumped) PATH=${NODE_INSTALL}/bin:${PATH} ${NODE_INSTALL}/bin/node --abort_on_uncaught_exception ${t}
     59670 Done                    | tee -a ${OUTPUT_DIR}/cloudapi.tap
Uncaught Error: Cannot find module '@smaller/tap'

FROM
Function.Module._resolveFilename (module.js:478:5)
Function.Module._load (module.js:424:25)
Module.require (module.js:504:17)
require (internal/module.js:20:19)
Object.<anonymous> (/opt/smartdc/cloudapi/test/plugins/free-tier.test.js:11:35)
Module._compile (module.js:577:32)
Object.Module._extensions..js (module.js:586:10)
Module.load (module.js:494:32)
tryModuleLoad (module.js:453:12)
Function.Module._load (module.js:445:3)
Module.runMain (module.js:611:10)
run (bootstrap_node.js:394:7)
startup (bootstrap_node.js:160:9)
bootstrap_node.js:507:3
./runtests: line 115: 59671 Illegal Instruction     (core dumped) PATH=${NODE_INSTALL}/bin:${PATH} ${NODE_INSTALL}/bin/node --abort_on_uncaught_exception ${t}
     59672 Done                    | tee -a ${OUTPUT_DIR}/cloudapi.tap
Uncaught Error: Cannot find module '@smaller/tap'

FROM
Function.Module._resolveFilename (module.js:478:5)
Function.Module._load (module.js:424:25)
Module.require (module.js:504:17)
require (internal/module.js:20:19)
Object.<anonymous> (/opt/smartdc/cloudapi/test/plugins/machine-email.test.js:11:35)
Module._compile (module.js:577:32)
Object.Module._extensions..js (module.js:586:10)
Module.load (module.js:494:32)
tryModuleLoad (module.js:453:12)
Function.Module._load (module.js:445:3)
Module.runMain (module.js:611:10)
run (bootstrap_node.js:394:7)
startup (bootstrap_node.js:160:9)
bootstrap_node.js:507:3
./runtests: line 115: 59673 Illegal Instruction     (core dumped) PATH=${NODE_INSTALL}/bin:${PATH} ${NODE_INSTALL}/bin/node --abort_on_uncaught_exception ${t}
     59674 Done                    | tee -a ${OUTPUT_DIR}/cloudapi.tap
Uncaught Error: Cannot find module '@smaller/tap'

FROM
Function.Module._resolveFilename (module.js:478:5)
Function.Module._load (module.js:424:25)
Module.require (module.js:504:17)
require (internal/module.js:20:19)
Object.<anonymous> (/opt/smartdc/cloudapi/test/plugins/plugin-manager.test.js:15:35)
Module._compile (module.js:577:32)
Object.Module._extensions..js (module.js:586:10)
Module.load (module.js:494:32)
tryModuleLoad (module.js:453:12)
Function.Module._load (module.js:445:3)
Module.runMain (module.js:611:10)
run (bootstrap_node.js:394:7)
startup (bootstrap_node.js:160:9)
bootstrap_node.js:507:3
./runtests: line 115: 59677 Illegal Instruction     (core dumped) PATH=${NODE_INSTALL}/bin:${PATH} ${NODE_INSTALL}/bin/node --abort_on_uncaught_exception ${t}
     59678 Done                    | tee -a ${OUTPUT_DIR}/cloudapi.tap
Uncaught Error: Cannot find module '@smaller/tap'

FROM
Function.Module._resolveFilename (module.js:478:5)
Function.Module._load (module.js:424:25)
Module.require (module.js:504:17)
require (internal/module.js:20:19)
Object.<anonymous> (/opt/smartdc/cloudapi/test/plugins/provision-limits.test.js:11:35)
Module._compile (module.js:577:32)
Object.Module._extensions..js (module.js:586:10)
Module.load (module.js:494:32)
tryModuleLoad (module.js:453:12)
Function.Module._load (module.js:445:3)
Module.runMain (module.js:611:10)
run (bootstrap_node.js:394:7)
startup (bootstrap_node.js:160:9)
bootstrap_node.js:507:3
./runtests: line 115: 59681 Illegal Instruction     (core dumped) PATH=${NODE_INSTALL}/bin:${PATH} ${NODE_INSTALL}/bin/node --abort_on_uncaught_exception ${t}
     59682 Done                    | tee -a ${OUTPUT_DIR}/cloudapi.tap
#
# TESTS COMPLETE IN 6 SECONDS, SUMMARY:
#
#   PASS: 0 / 0
#

After:

[root@e5ad067e-ae5e-4505-933b-a31190be1489 (lab:cloudapi0) /opt/smartdc/cloudapi/test]# ./runtests -f plugins
/opt/smartdc/cloudapi
# Setup a clean output dir (/var/tmp/cloudapitest).
# Running filtered set of test files: test/plugins/filter-owner-networks.test.js
test/plugins/free-tier.test.js
test/plugins/machine-email.test.js
test/plugins/plugin-manager.test.js
test/plugins/provision-limits.test.js
TAP version 13
[...]
#
# TESTS COMPLETE IN 4 SECONDS, SUMMARY:
#
#   PASS: 738 / 738
#